Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go client patch #636

Merged
merged 7 commits into from
Feb 28, 2023
Merged

Go client patch #636

merged 7 commits into from
Feb 28, 2023

Conversation

DDefiebre
Copy link
Contributor

@DDefiebre DDefiebre commented Feb 27, 2023

Added Patch to Go Client for User and Item

Copy link
Collaborator

@zhenghaoz zhenghaoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😺 Thanks for your contribution. There are some suggestions on this PR.

@codecov
Copy link

codecov bot commented Feb 27, 2023

Codecov Report

Base: 70.50% // Head: 70.50% // No change to project coverage 👍

Coverage data is based on head (34daca1) compared to base (bcc601b).
Patch has no changes to coverable lines.

❗ Current head 34daca1 differs from pull request most recent head f5f45bd. Consider uploading reports for the commit f5f45bd to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #636   +/-   ##
=======================================
  Coverage   70.50%   70.50%           
=======================================
  Files          63       63           
  Lines       12495    12495           
=======================================
  Hits         8810     8810           
  Misses       2837     2837           
  Partials      848      848           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@DDefiebre DDefiebre requested a review from zhenghaoz February 28, 2023 08:47
@DDefiebre
Copy link
Contributor Author

@zhenghaoz I had done the requested changes, can you review again?

@zhenghaoz
Copy link
Collaborator

Thanks for your contribution. This PR will be merged once all tests pass.

@zhenghaoz zhenghaoz merged commit 080d32c into gorse-io:master Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants