Optimize exception messages to contain helpful debug information

neetopia · neetopia · commit 17778fcfaf49 · 2020-11-19T22:45:13.000-08:00
diff --git a/api/src/main/kotlin/com/google/devtools/ksp/utils.kt b/api/src/main/kotlin/com/google/devtools/ksp/utils.kt
@@ -132,7 +132,7 @@ fun KSClassDeclaration.getAllSuperTypes(): Sequence<KSType> {
                 is KSClassDeclaration -> sequenceOf(resolvedDeclaration)
                 is KSTypeAlias -> sequenceOf(resolvedDeclaration.findActualType())
                 is KSTypeParameter -> resolvedDeclaration.getTypesUpperBound()
-                else -> throw IllegalStateException()
+                else -> throw IllegalStateException("unhandled type parameter bound, $ExceptionMessage")
             }
         }
 
@@ -148,7 +148,7 @@ fun KSClassDeclaration.getAllSuperTypes(): Sequence<KSType> {
                         is KSClassDeclaration -> it.getAllSuperTypes()
                         is KSTypeAlias -> it.findActualType().getAllSuperTypes()
                         is KSTypeParameter -> it.getTypesUpperBound().flatMap { it.getAllSuperTypes() }
-                        else -> throw IllegalStateException()
+                        else -> throw IllegalStateException("unhandled super type kind, $ExceptionMessage")
                     }
                 }
         )
@@ -243,3 +243,5 @@ fun KSDeclaration.isVisibleFrom(other: KSDeclaration): Boolean {
     }
 
 }
+
+const val ExceptionMessage = "please file a bug at https://github.com/google/ksp/issues/new"
diff --git a/api/src/main/kotlin/com/google/devtools/ksp/visitor/KSValidateVisitor.kt b/api/src/main/kotlin/com/google/devtools/ksp/visitor/KSValidateVisitor.kt
@@ -1,5 +1,6 @@
 package com.google.devtools.ksp.visitor
 
+import com.google.devtools.ksp.ExceptionMessage
 import com.google.devtools.ksp.symbol.*
 
 class KSValidateVisitor(private val predicate: (KSNode, KSNode) -> Boolean) : KSDefaultVisitor<Unit, Boolean>() {
@@ -16,7 +17,7 @@ class KSValidateVisitor(private val predicate: (KSNode, KSNode) -> Boolean) : KS
     }
 
     override fun defaultHandler(node: KSNode, data: Unit): Boolean {
-        throw IllegalStateException("unhandled validation condition, please file a bug at https://github.com/google/ksp/issues/new")
+        throw IllegalStateException("unhandled validation condition, $ExceptionMessage")
     }
 
     override fun visitTypeReference(typeReference: KSTypeReference, data: Unit): Boolean {
diff --git a/compiler-plugin/src/main/kotlin/com/google/devtools/ksp/processing/impl/CodeGeneratorImpl.kt b/compiler-plugin/src/main/kotlin/com/google/devtools/ksp/processing/impl/CodeGeneratorImpl.kt
@@ -46,7 +46,7 @@ class CodeGeneratorImpl(
         val file = File(path)
         val parentFile = file.parentFile
         if (!parentFile.exists() && !parentFile.mkdirs()) {
-            throw IllegalStateException()
+            throw IllegalStateException("failed to make parent directories.")
         }
         file.writeText("")
         fileMap[path] = file
diff --git a/compiler-plugin/src/main/kotlin/com/google/devtools/ksp/processing/impl/ResolverImpl.kt b/compiler-plugin/src/main/kotlin/com/google/devtools/ksp/processing/impl/ResolverImpl.kt
@@ -18,10 +18,7 @@
 
 package com.google.devtools.ksp.processing.impl
 
-import com.google.devtools.ksp.KspExperimental
-import com.google.devtools.ksp.closestClassDeclaration
-import com.google.devtools.ksp.isOpen
-import com.google.devtools.ksp.isVisibleFrom
+import com.google.devtools.ksp.*
 import com.intellij.openapi.project.Project
 import com.intellij.psi.*
 import com.intellij.psi.impl.source.PsiClassReferenceType
@@ -442,7 +439,7 @@ class ResolverImpl(
                     return getKSTypeCached(resolveJavaType(type.psi), type.element.typeArguments, type.annotations)
                 }
             }
-            else -> throw IllegalStateException()
+            else -> throw IllegalStateException("Unable to resolve type for $type, $ExceptionMessage")
         }
     }
 
@@ -454,13 +451,14 @@ class ResolverImpl(
                 is KtClassOrObject -> KSClassDeclarationImpl.getCached(psi)
                 is PsiClass -> KSClassDeclarationJavaImpl.getCached(psi)
                 is KtTypeAlias -> KSTypeAliasImpl.getCached(psi)
-                else -> throw IllegalStateException()
+                else -> throw IllegalStateException("Unexpected psi type: ${psi.javaClass}, $ExceptionMessage")
             }
         } else {
             when (descriptor) {
                 is ClassDescriptor -> KSClassDeclarationDescriptorImpl.getCached(descriptor)
                 is TypeParameterDescriptor -> KSTypeParameterDescriptorImpl.getCached(descriptor)
-                else -> throw IllegalStateException()
+                null -> throw IllegalStateException("Failed to resolve descriptor for $kotlinType")
+                else -> throw IllegalStateException("Unexpected descriptor type: ${descriptor.javaClass}, $ExceptionMessage")
             }
         }
     }
diff --git a/compiler-plugin/src/main/kotlin/com/google/devtools/ksp/symbol/impl/binary/KSAnnotationDescriptorImpl.kt b/compiler-plugin/src/main/kotlin/com/google/devtools/ksp/symbol/impl/binary/KSAnnotationDescriptorImpl.kt
@@ -18,6 +18,7 @@
 
 package com.google.devtools.ksp.symbol.impl.binary
 
+import com.google.devtools.ksp.ExceptionMessage
 import com.intellij.psi.JavaPsiFacade
 import com.intellij.psi.PsiAnnotationMethod
 import org.jetbrains.kotlin.descriptors.ClassConstructorDescriptor
@@ -122,6 +123,6 @@ fun ValueParameterDescriptor.getDefaultValue(): Any? {
         }
         is KtParameter -> ResolverImpl.instance.evaluateConstant(psi.defaultValue, this.type)?.value
         is PsiAnnotationMethod -> JavaPsiFacade.getInstance(psi.project).constantEvaluationHelper.computeConstantExpression((psi).defaultValue)
-        else -> throw IllegalStateException()
+        else -> throw IllegalStateException("Unexpected psi ${psi.javaClass}, $ExceptionMessage")
     }
 }
diff --git a/compiler-plugin/src/main/kotlin/com/google/devtools/ksp/symbol/impl/binary/KSClassDeclarationDescriptorImpl.kt b/compiler-plugin/src/main/kotlin/com/google/devtools/ksp/symbol/impl/binary/KSClassDeclarationDescriptorImpl.kt
@@ -18,6 +18,7 @@
 
 package com.google.devtools.ksp.symbol.impl.binary
 
+import com.google.devtools.ksp.ExceptionMessage
 import org.jetbrains.kotlin.descriptors.*
 import com.google.devtools.ksp.symbol.*
 import com.google.devtools.ksp.symbol.impl.KSObjectCache
@@ -91,7 +92,7 @@ class KSClassDeclarationDescriptorImpl private constructor(val descriptor: Class
                     is PropertyDescriptor -> KSPropertyDeclarationDescriptorImpl.getCached(it)
                     is FunctionDescriptor -> KSFunctionDeclarationDescriptorImpl.getCached(it)
                     is ClassDescriptor -> getCached(it)
-                    else -> throw IllegalStateException()
+                    else -> throw IllegalStateException("Unexpected descriptor type ${it.javaClass}, $ExceptionMessage")
                 }
             }
     }
diff --git a/compiler-plugin/src/main/kotlin/com/google/devtools/ksp/symbol/impl/binary/KSFunctionDeclarationDescriptorImpl.kt b/compiler-plugin/src/main/kotlin/com/google/devtools/ksp/symbol/impl/binary/KSFunctionDeclarationDescriptorImpl.kt
@@ -18,6 +18,7 @@
 
 package com.google.devtools.ksp.symbol.impl.binary
 
+import com.google.devtools.ksp.ExceptionMessage
 import org.jetbrains.kotlin.descriptors.FunctionDescriptor
 import org.jetbrains.kotlin.descriptors.impl.AnonymousFunctionDescriptor
 import com.google.devtools.ksp.isOpen
@@ -31,6 +32,7 @@ import com.google.devtools.ksp.symbol.impl.toKSFunctionDeclaration
 import com.google.devtools.ksp.symbol.impl.toKSModifiers
 import org.jetbrains.kotlin.load.java.isFromJava
 import org.jetbrains.kotlin.resolve.OverridingUtil
+import org.jetbrains.kotlin.resolve.descriptorUtil.fqNameSafe
 
 class KSFunctionDeclarationDescriptorImpl private constructor(val descriptor: FunctionDescriptor) : KSFunctionDeclaration,
     KSDeclarationDescriptorImpl(descriptor),
@@ -64,7 +66,7 @@ class KSFunctionDeclarationDescriptorImpl private constructor(val descriptor: Fu
             descriptor.dispatchReceiverParameter == null -> if (descriptor.isFromJava) FunctionKind.STATIC else FunctionKind.TOP_LEVEL
             !descriptor.name.isSpecial && !descriptor.name.asString().isEmpty() -> FunctionKind.MEMBER
             descriptor is AnonymousFunctionDescriptor -> FunctionKind.ANONYMOUS
-            else -> throw IllegalStateException()
+            else -> throw IllegalStateException("Unable to resolve FunctionKind for ${descriptor.fqNameSafe}, $ExceptionMessage")
         }
     }
 
diff --git a/compiler-plugin/src/main/kotlin/com/google/devtools/ksp/symbol/impl/binary/KSPropertySetterDescriptorImpl.kt b/compiler-plugin/src/main/kotlin/com/google/devtools/ksp/symbol/impl/binary/KSPropertySetterDescriptorImpl.kt
@@ -29,7 +29,8 @@ class KSPropertySetterDescriptorImpl private constructor(descriptor: PropertySet
     }
 
     override val parameter: KSValueParameter by lazy {
-        descriptor.valueParameters.singleOrNull()?.let { KSValueParameterDescriptorImpl.getCached(it) } ?: throw IllegalStateException()
+        descriptor.valueParameters.singleOrNull()?.let { KSValueParameterDescriptorImpl.getCached(it) }
+                ?: throw IllegalStateException("Failed to resolve property type")
     }
 
     override fun <D, R> accept(visitor: KSVisitor<D, R>, data: D): R {
diff --git a/compiler-plugin/src/main/kotlin/com/google/devtools/ksp/symbol/impl/binary/KSTypeParameterDescriptorImpl.kt b/compiler-plugin/src/main/kotlin/com/google/devtools/ksp/symbol/impl/binary/KSTypeParameterDescriptorImpl.kt
@@ -18,6 +18,7 @@
 
 package com.google.devtools.ksp.symbol.impl.binary
 
+import com.google.devtools.ksp.ExceptionMessage
 import org.jetbrains.kotlin.descriptors.ClassDescriptor
 import org.jetbrains.kotlin.descriptors.FunctionDescriptor
 import org.jetbrains.kotlin.descriptors.PropertyDescriptor
@@ -47,7 +48,7 @@ class KSTypeParameterDescriptorImpl private constructor(val descriptor: TypePara
             is ClassDescriptor -> KSClassDeclarationDescriptorImpl.getCached(parent)
             is FunctionDescriptor -> KSFunctionDeclarationDescriptorImpl.getCached(parent)
             is PropertyDescriptor -> KSPropertyDeclarationDescriptorImpl.getCached(parent)
-            else -> throw IllegalStateException()
+            else -> throw IllegalStateException("Unexpected containing declaration for ${descriptor.fqNameSafe}, $ExceptionMessage")
         }
     }
 
diff --git a/compiler-plugin/src/main/kotlin/com/google/devtools/ksp/symbol/impl/binary/KSTypeReferenceDescriptorImpl.kt b/compiler-plugin/src/main/kotlin/com/google/devtools/ksp/symbol/impl/binary/KSTypeReferenceDescriptorImpl.kt
@@ -18,6 +18,7 @@
 
 package com.google.devtools.ksp.symbol.impl.binary
 
+import com.google.devtools.ksp.ExceptionMessage
 import org.jetbrains.kotlin.builtins.isSuspendFunctionTypeOrSubtype
 import org.jetbrains.kotlin.descriptors.ClassDescriptor
 import org.jetbrains.kotlin.descriptors.TypeParameterDescriptor
@@ -44,10 +45,10 @@ class KSTypeReferenceDescriptorImpl private constructor(val kotlinType: KotlinTy
                 when (upperBound) {
                     is FlexibleType -> KSClassifierReferenceDescriptorImpl.getCached(upperBound.upperBound)
                     is SimpleType -> KSClassifierReferenceDescriptorImpl.getCached(upperBound)
-                    else -> throw IllegalStateException()
+                    else -> throw IllegalStateException("Unexpected upperbound type ${upperBound.javaClass}, $ExceptionMessage")
                 }
             }
-            else -> throw IllegalStateException()
+            else -> throw IllegalStateException("Unexpected type: ${kotlinType.constructor.declarationDescriptor?.javaClass}, $ExceptionMessage")
         }
     }
 
diff --git a/compiler-plugin/src/main/kotlin/com/google/devtools/ksp/symbol/impl/java/KSTypeReferenceJavaImpl.kt b/compiler-plugin/src/main/kotlin/com/google/devtools/ksp/symbol/impl/java/KSTypeReferenceJavaImpl.kt
@@ -18,6 +18,7 @@
 
 package com.google.devtools.ksp.symbol.impl.java
 
+import com.google.devtools.ksp.ExceptionMessage
 import com.intellij.psi.*
 import com.intellij.psi.impl.source.PsiClassReferenceType
 import com.google.devtools.ksp.processing.impl.ResolverImpl
@@ -62,7 +63,7 @@ class KSTypeReferenceJavaImpl private constructor(val psi: PsiType) : KSTypeRefe
                 "char" -> ResolverImpl.instance.module.builtIns.charType
                 "boolean" -> ResolverImpl.instance.module.builtIns.booleanType
                 "void" -> ResolverImpl.instance.module.builtIns.unitType
-                else -> throw IllegalStateException()
+                else -> throw IllegalStateException("Unexpected primitive type ${this.name}, $ExceptionMessage")
             }
         }
 
@@ -88,7 +89,7 @@ class KSTypeReferenceJavaImpl private constructor(val psi: PsiType) : KSTypeRefe
                 }
             }
             null -> KSClassifierReferenceDescriptorImpl.getCached((ResolverImpl.instance.builtIns.anyType as KSTypeImpl).kotlinType.makeNullable())
-            else -> throw IllegalStateException()
+            else -> throw IllegalStateException("Unexpected psi type for ${type.javaClass}, $ExceptionMessage")
         }
     }
 
diff --git a/compiler-plugin/src/main/kotlin/com/google/devtools/ksp/symbol/impl/kotlin/KSFunctionDeclarationImpl.kt b/compiler-plugin/src/main/kotlin/com/google/devtools/ksp/symbol/impl/kotlin/KSFunctionDeclarationImpl.kt
@@ -18,6 +18,7 @@
 
 package com.google.devtools.ksp.symbol.impl.kotlin
 
+import com.google.devtools.ksp.ExceptionMessage
 import org.jetbrains.kotlin.descriptors.FunctionDescriptor
 import com.google.devtools.ksp.isOpen
 import com.google.devtools.ksp.isVisibleFrom
@@ -65,7 +66,7 @@ class KSFunctionDeclarationImpl private constructor(val ktFunction: KtFunction)
             when (ktFunction) {
                 is KtNamedFunction, is KtPrimaryConstructor, is KtSecondaryConstructor -> FunctionKind.MEMBER
                 is KtFunctionLiteral -> if (ktFunction.node.findChildByType(KtTokens.FUN_KEYWORD) != null) FunctionKind.ANONYMOUS else FunctionKind.LAMBDA
-                else -> throw IllegalStateException()
+                else -> throw IllegalStateException("Unexpected psi type ${ktFunction.javaClass}, $ExceptionMessage")
             }
         }
     }
diff --git a/compiler-plugin/src/main/kotlin/com/google/devtools/ksp/symbol/impl/kotlin/KSPropertySetterImpl.kt b/compiler-plugin/src/main/kotlin/com/google/devtools/ksp/symbol/impl/kotlin/KSPropertySetterImpl.kt
@@ -30,7 +30,7 @@ class KSPropertySetterImpl private constructor(ktPropertySetter: KtPropertyAcces
 
     override val parameter: KSValueParameter by lazy {
         ktPropertySetter.parameterList?.parameters?.singleOrNull()?.let { KSValueParameterImpl.getCached(it) }
-            ?: throw IllegalStateException()
+            ?: throw IllegalStateException("Failed to resolve property type")
     }
 
     override fun <D, R> accept(visitor: KSVisitor<D, R>, data: D): R {
diff --git a/compiler-plugin/src/main/kotlin/com/google/devtools/ksp/symbol/impl/kotlin/KSTypeParameterImpl.kt b/compiler-plugin/src/main/kotlin/com/google/devtools/ksp/symbol/impl/kotlin/KSTypeParameterImpl.kt
@@ -18,6 +18,7 @@
 
 package com.google.devtools.ksp.symbol.impl.kotlin
 
+import com.google.devtools.ksp.ExceptionMessage
 import com.google.devtools.ksp.symbol.*
 import com.google.devtools.ksp.symbol.impl.KSObjectCache
 import com.google.devtools.ksp.symbol.impl.toKSModifiers
@@ -71,7 +72,7 @@ class KSTypeParameterImpl private constructor(val ktTypeParameter: KtTypeParamet
             is KtClassOrObject -> KSClassDeclarationImpl.getCached(owner)
             is KtFunction -> KSFunctionDeclarationImpl.getCached(owner)
             is KtProperty -> KSPropertyDeclarationImpl.getCached(owner)
-            else -> throw IllegalStateException()
+            else -> throw IllegalStateException("Unexpected containing declaration type ${owner.javaClass}, $ExceptionMessage")
         }
     }
 
diff --git a/compiler-plugin/src/main/kotlin/com/google/devtools/ksp/symbol/impl/kotlin/KSTypeReferenceImpl.kt b/compiler-plugin/src/main/kotlin/com/google/devtools/ksp/symbol/impl/kotlin/KSTypeReferenceImpl.kt
@@ -18,6 +18,7 @@
 
 package com.google.devtools.ksp.symbol.impl.kotlin
 
+import com.google.devtools.ksp.ExceptionMessage
 import com.google.devtools.ksp.processing.impl.ResolverImpl
 import com.google.devtools.ksp.symbol.*
 import com.google.devtools.ksp.symbol.impl.KSObjectCache
@@ -53,7 +54,7 @@ class KSTypeReferenceImpl private constructor(val ktTypeReference: KtTypeReferen
             is KtFunctionType -> KSCallableReferenceImpl.getCached(typeElement)
             is KtUserType -> KSClassifierReferenceImpl.getCached(typeElement)
             is KtDynamicType -> KSDynamicReferenceImpl.getCached(Unit)
-            else -> throw IllegalStateException()
+            else -> throw IllegalStateException("Unexpected type element ${typeElement?.javaClass}, $ExceptionMessage")
         }
     }
 
diff --git a/compiler-plugin/src/main/kotlin/com/google/devtools/ksp/symbol/impl/synthetic/KSPropertySetterSyntheticImpl.kt b/compiler-plugin/src/main/kotlin/com/google/devtools/ksp/symbol/impl/synthetic/KSPropertySetterSyntheticImpl.kt
@@ -39,7 +39,8 @@ class KSPropertySetterSyntheticImpl(val ksPropertyDeclaration: KSPropertyDeclara
     }
 
     override val parameter: KSValueParameter by lazy {
-        descriptor.valueParameters.singleOrNull()?.let { KSValueParameterDescriptorImpl.getCached(it) } ?: throw IllegalStateException()
+        descriptor.valueParameters.singleOrNull()?.let { KSValueParameterDescriptorImpl.getCached(it) }
+                ?: throw IllegalStateException("Failed to resolve property type")
     }
 
     override fun <D, R> accept(visitor: KSVisitor<D, R>, data: D): R {
diff --git a/compiler-plugin/src/main/kotlin/com/google/devtools/ksp/symbol/impl/utils.kt b/compiler-plugin/src/main/kotlin/com/google/devtools/ksp/symbol/impl/utils.kt
@@ -18,6 +18,7 @@
 
 package com.google.devtools.ksp.symbol.impl
 
+import com.google.devtools.ksp.ExceptionMessage
 import com.intellij.lang.jvm.JvmModifier
 import com.intellij.psi.*
 import org.jetbrains.kotlin.descriptors.*
@@ -209,7 +210,7 @@ fun KtClassOrObject.getClassType(): ClassKind {
             this.isAnnotation() -> ClassKind.ANNOTATION_CLASS
             else -> ClassKind.CLASS
         }
-        else -> throw IllegalStateException()
+        else -> throw IllegalStateException("Unexpected psi type ${this.javaClass}, $ExceptionMessage")
     }
 }
 
@@ -228,7 +229,7 @@ fun org.jetbrains.kotlin.types.Variance.toKSVariance(): Variance {
         org.jetbrains.kotlin.types.Variance.IN_VARIANCE -> Variance.CONTRAVARIANT
         org.jetbrains.kotlin.types.Variance.OUT_VARIANCE -> Variance.COVARIANT
         org.jetbrains.kotlin.types.Variance.INVARIANT -> Variance.INVARIANT
-        else -> throw IllegalStateException()
+        else -> throw IllegalStateException("Unexpected variance value $this, $ExceptionMessage")
     }
 }
 
@@ -246,7 +247,7 @@ internal fun KotlinType.replaceTypeArguments(newArguments: List<KSTypeArgument>)
         val type = when (ksTypeArgument) {
             is KSTypeArgumentKtImpl, is KSTypeArgumentJavaImpl, is KSTypeArgumentLiteImpl -> ksTypeArgument.type!!
             is KSTypeArgumentDescriptorImpl -> return@mapIndexed ksTypeArgument.descriptor
-            else -> throw IllegalStateException()
+            else -> throw IllegalStateException("Unexpected psi for type argument: ${ksTypeArgument.javaClass}, $ExceptionMessage")
         }.toKotlinType()
 
         TypeProjectionImpl(variance, type)

Original file line number	Diff line number	Diff line change
`@@ -132,7 +132,7 @@ fun KSClassDeclaration.getAllSuperTypes(): Sequence<KSType> {`
`132`	`132`	`is KSClassDeclaration -> sequenceOf(resolvedDeclaration)`
`133`	`133`	`is KSTypeAlias -> sequenceOf(resolvedDeclaration.findActualType())`
`134`	`134`	`is KSTypeParameter -> resolvedDeclaration.getTypesUpperBound()`
`135`		`- else -> throw IllegalStateException()`
	`135`	`+ else -> throw IllegalStateException("unhandled type parameter bound, $ExceptionMessage")`
`136`	`136`	`}`
`137`	`137`	`}`
`138`	`138`
`@@ -148,7 +148,7 @@ fun KSClassDeclaration.getAllSuperTypes(): Sequence<KSType> {`
`148`	`148`	`is KSClassDeclaration -> it.getAllSuperTypes()`
`149`	`149`	`is KSTypeAlias -> it.findActualType().getAllSuperTypes()`
`150`	`150`	`is KSTypeParameter -> it.getTypesUpperBound().flatMap { it.getAllSuperTypes() }`
`151`		`- else -> throw IllegalStateException()`
	`151`	`+ else -> throw IllegalStateException("unhandled super type kind, $ExceptionMessage")`
`152`	`152`	`}`
`153`	`153`	`}`
`154`	`154`	`)`
`@@ -243,3 +243,5 @@ fun KSDeclaration.isVisibleFrom(other: KSDeclaration): Boolean {`
`243`	`243`	`}`
`244`	`244`
`245`	`245`	`}`
	`246`	`+`
	`247`	`+const val ExceptionMessage = "please file a bug at https://github.com/google/ksp/issues/new"`
Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,6 @@`
`1`	`1`	`package com.google.devtools.ksp.visitor`
`2`	`2`
	`3`	`+import com.google.devtools.ksp.ExceptionMessage`
`3`	`4`	`import com.google.devtools.ksp.symbol.*`
`4`	`5`
`5`	`6`	`class KSValidateVisitor(private val predicate: (KSNode, KSNode) -> Boolean) : KSDefaultVisitor<Unit, Boolean>() {`
`@@ -16,7 +17,7 @@ class KSValidateVisitor(private val predicate: (KSNode, KSNode) -> Boolean) : KS`
`16`	`17`	`}`
`17`	`18`
`18`	`19`	`override fun defaultHandler(node: KSNode, data: Unit): Boolean {`
`19`		`- throw IllegalStateException("unhandled validation condition, please file a bug at https://github.com/google/ksp/issues/new")`
	`20`	`+ throw IllegalStateException("unhandled validation condition, $ExceptionMessage")`
`20`	`21`	`}`
`21`	`22`
`22`	`23`	`override fun visitTypeReference(typeReference: KSTypeReference, data: Unit): Boolean {`
Original file line number	Diff line number	Diff line change
`@@ -46,7 +46,7 @@ class CodeGeneratorImpl(`
`46`	`46`	`val file = File(path)`
`47`	`47`	`val parentFile = file.parentFile`
`48`	`48`	`if (!parentFile.exists() && !parentFile.mkdirs()) {`
`49`		`- throw IllegalStateException()`
	`49`	`+ throw IllegalStateException("failed to make parent directories.")`
`50`	`50`	`}`
`51`	`51`	`file.writeText("")`
`52`	`52`	`fileMap[path] = file`
Original file line number	Diff line number	Diff line change
`@@ -18,10 +18,7 @@`
`18`	`18`
`19`	`19`	`package com.google.devtools.ksp.processing.impl`
`20`	`20`
`21`		`-import com.google.devtools.ksp.KspExperimental`
`22`		`-import com.google.devtools.ksp.closestClassDeclaration`
`23`		`-import com.google.devtools.ksp.isOpen`
`24`		`-import com.google.devtools.ksp.isVisibleFrom`
	`21`	`+import com.google.devtools.ksp.*`
`25`	`22`	`import com.intellij.openapi.project.Project`
`26`	`23`	`import com.intellij.psi.*`
`27`	`24`	`import com.intellij.psi.impl.source.PsiClassReferenceType`
`@@ -442,7 +439,7 @@ class ResolverImpl(`
`442`	`439`	`return getKSTypeCached(resolveJavaType(type.psi), type.element.typeArguments, type.annotations)`
`443`	`440`	`}`
`444`	`441`	`}`
`445`		`- else -> throw IllegalStateException()`
	`442`	`+ else -> throw IllegalStateException("Unable to resolve type for $type, $ExceptionMessage")`
`446`	`443`	`}`
`447`	`444`	`}`
`448`	`445`
`@@ -454,13 +451,14 @@ class ResolverImpl(`
`454`	`451`	`is KtClassOrObject -> KSClassDeclarationImpl.getCached(psi)`
`455`	`452`	`is PsiClass -> KSClassDeclarationJavaImpl.getCached(psi)`
`456`	`453`	`is KtTypeAlias -> KSTypeAliasImpl.getCached(psi)`
`457`		`- else -> throw IllegalStateException()`
	`454`	`+ else -> throw IllegalStateException("Unexpected psi type: ${psi.javaClass}, $ExceptionMessage")`
`458`	`455`	`}`
`459`	`456`	`} else {`
`460`	`457`	`when (descriptor) {`
`461`	`458`	`is ClassDescriptor -> KSClassDeclarationDescriptorImpl.getCached(descriptor)`
`462`	`459`	`is TypeParameterDescriptor -> KSTypeParameterDescriptorImpl.getCached(descriptor)`
`463`		`- else -> throw IllegalStateException()`
	`460`	`+ null -> throw IllegalStateException("Failed to resolve descriptor for $kotlinType")`
	`461`	`+ else -> throw IllegalStateException("Unexpected descriptor type: ${descriptor.javaClass}, $ExceptionMessage")`
`464`	`462`	`}`
`465`	`463`	`}`
`466`	`464`	`}`
Original file line number	Diff line number	Diff line change
`@@ -18,6 +18,7 @@`
`18`	`18`
`19`	`19`	`package com.google.devtools.ksp.symbol.impl.binary`
`20`	`20`
	`21`	`+import com.google.devtools.ksp.ExceptionMessage`
`21`	`22`	`import com.intellij.psi.JavaPsiFacade`
`22`	`23`	`import com.intellij.psi.PsiAnnotationMethod`
`23`	`24`	`import org.jetbrains.kotlin.descriptors.ClassConstructorDescriptor`
`@@ -122,6 +123,6 @@ fun ValueParameterDescriptor.getDefaultValue(): Any? {`
`122`	`123`	`}`
`123`	`124`	`is KtParameter -> ResolverImpl.instance.evaluateConstant(psi.defaultValue, this.type)?.value`
`124`	`125`	`is PsiAnnotationMethod -> JavaPsiFacade.getInstance(psi.project).constantEvaluationHelper.computeConstantExpression((psi).defaultValue)`
`125`		`- else -> throw IllegalStateException()`
	`126`	`+ else -> throw IllegalStateException("Unexpected psi ${psi.javaClass}, $ExceptionMessage")`
`126`	`127`	`}`
`127`	`128`	`}`
Original file line number	Diff line number	Diff line change
`@@ -29,7 +29,8 @@ class KSPropertySetterDescriptorImpl private constructor(descriptor: PropertySet`
`29`	`29`	`}`
`30`	`30`
`31`	`31`	`override val parameter: KSValueParameter by lazy {`
`32`		`- descriptor.valueParameters.singleOrNull()?.let { KSValueParameterDescriptorImpl.getCached(it) } ?: throw IllegalStateException()`
	`32`	`+ descriptor.valueParameters.singleOrNull()?.let { KSValueParameterDescriptorImpl.getCached(it) }`
	`33`	`+ ?: throw IllegalStateException("Failed to resolve property type")`
`33`	`34`	`}`
`34`	`35`
`35`	`36`	`override fun <D, R> accept(visitor: KSVisitor<D, R>, data: D): R {`
Original file line number	Diff line number	Diff line change
`@@ -30,7 +30,7 @@ class KSPropertySetterImpl private constructor(ktPropertySetter: KtPropertyAcces`
`30`	`30`
`31`	`31`	`override val parameter: KSValueParameter by lazy {`
`32`	`32`	`ktPropertySetter.parameterList?.parameters?.singleOrNull()?.let { KSValueParameterImpl.getCached(it) }`
`33`		`- ?: throw IllegalStateException()`
	`33`	`+ ?: throw IllegalStateException("Failed to resolve property type")`
`34`	`34`	`}`
`35`	`35`
`36`	`36`	`override fun <D, R> accept(visitor: KSVisitor<D, R>, data: D): R {`
Original file line number	Diff line number	Diff line change
`@@ -39,7 +39,8 @@ class KSPropertySetterSyntheticImpl(val ksPropertyDeclaration: KSPropertyDeclara`
`39`	`39`	`}`
`40`	`40`
`41`	`41`	`override val parameter: KSValueParameter by lazy {`
`42`		`- descriptor.valueParameters.singleOrNull()?.let { KSValueParameterDescriptorImpl.getCached(it) } ?: throw IllegalStateException()`
	`42`	`+ descriptor.valueParameters.singleOrNull()?.let { KSValueParameterDescriptorImpl.getCached(it) }`
	`43`	`+ ?: throw IllegalStateException("Failed to resolve property type")`
`43`	`44`	`}`
`44`	`45`
`45`	`46`	`override fun <D, R> accept(visitor: KSVisitor<D, R>, data: D): R {`