x/text/cmd/gotext: extract only matches printer.Sprintf calls, not printer.Sprint calls

[SamWhited]

Go version

go version go1.23.1 linux/amd64

Output of go env in your module/workspace:

GO111MODULE='on'
GOARCH='amd64'
GOBIN=''
GOCACHE='/home/sam/.cache/go-build'
GOENV='/home/sam/.config/go/env'
GOEXE=''
GOEXPERIMENT=''
GOFLAGS=''
GOHOSTARCH='amd64'
GOHOSTOS='linux'
GOINSECURE=''
GOMODCACHE='/home/sam/go/pkg/mod'
GONOPROXY=''
GONOSUMDB=''
GOOS='linux'
GOPATH='/home/sam/go'
GOPRIVATE=''
GOPROXY='https://proxy.golang.org,direct'
GOROOT='/usr/lib/go'
GOSUMDB='sum.golang.org'
GOTMPDIR=''
GOTOOLCHAIN='auto'
GOTOOLDIR='/usr/lib/go/pkg/tool/linux_amd64'
GOVCS=''
GOVERSION='go1.23.1'
GODEBUG=''
GOTELEMETRY='local'
GOTELEMETRYDIR='/home/sam/.config/go/telemetry'
GCCGO='gccgo'
GOAMD64='v1'
AR='ar'
CC='gcc'
CXX='g++'
CGO_ENABLED='1'
GOMOD='/home/sam/gotest/go.mod'
GOWORK=''
CGO_CFLAGS='-O2 -g'
CGO_CPPFLAGS=''
CGO_CXXFLAGS='-O2 -g'
CGO_FFLAGS='-O2 -g'
CGO_LDFLAGS='-O2 -g'
PKG_CONFIG='pkg-config'
GOGCCFLAGS='-fPIC -m64 -pthread -Wl,--no-gc-sections -fmessage-length=0 -ffile-prefix-map=/tmp/go-build4124639609=/tmp/go-build -gno-record-gcc-switches'

What did you do?

Put the following MWE in a module and run go generate

(Playground: https://go.dev/play/p/uBxxYhGtldB)

package main

//go:generate gotext extract .
import (
	"fmt"

	"golang.org/x/text/message"
)

func main() {
	p := message.NewPrinter(message.MatchLanguage("en"))

	fmt.Println(p.Sprint("One"))
	fmt.Println(p.Sprintf("Two: %v", "three"))
}

What did you see happen?

The first string ("One") is not extracted to "locales/en-US/out.gotext.json" and won't be in your translations file. The second string is extracted correctly.

What did you expect to see?

Both strings are extracted to "locales/en-US/out.gotext.json"

[gabyhelp]

Related Issues and Documentation

• x/text/cmd/gotext: "/" not extracted #50288 (closed)
• x/text/cmd/gotext: support `...` patterns #51866
• x/text/cmd/gotext: misbehaviors of `gotext extract` and `gotext generate` #56842 (closed)
• x/text/cmd/gotext: gotext extract fails on type incompatibility issues #29217
• x/text/cmd/gotext: gotext created catalog_gen.go returns wrong value for non-existing keys #35587 (closed)
• x/text: printer.Printf works but printer.Print does not (all variants of print/printf) #41781
• x/text/cmd/gotext: Error extracting constant text from other files #64842
• x/text/message: does gotext extract variable that starts with "msg"? #66128 (closed)
• x/text/message: expected behaviour of message.Print is unclear #63173
• x/text/cmd/gotext: panic when do extract #62697 (closed)

_{(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)}

[SamWhited]

Oops, looks like a duplicate of #41781. Apologies.