Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: cmd definition tests are flaky #32794

Closed
stamblerre opened this issue Jun 26, 2019 · 4 comments
Closed

x/tools/gopls: cmd definition tests are flaky #32794

stamblerre opened this issue Jun 26, 2019 · 4 comments
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Soon This needs action soon. (recent regressions, service outages, unusual time-sensitive situations) Testing An issue that has been verified to require only test changes, not just a test failure. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gopls/v0.5.3

Comments

@stamblerre
Copy link
Contributor

The gopls cmd defintion tests tend to be flaky/inconsistent in some way.
To reproduce, run go test ./internal/lsp/cmd -run=TestDefinitionHelpExample -v -count=2. There should be unexpected errors in the logs.
They have been temporarily disabled by https://golang.org/cl/183628, but they should be fixed and re-enabled.
@gopherbot gopherbot added this to the Unreleased milestone Jun 26, 2019
@gopherbot gopherbot added the gopls Issues related to the Go language server, gopls. label Jun 26, 2019
@stamblerre stamblerre added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Jun 26, 2019
@dmitshur dmitshur added the Testing An issue that has been verified to require only test changes, not just a test failure. label Jun 27, 2019
@gopherbot gopherbot added the Tools This label describes issues relating to any tools in the x/tools repository. label Sep 12, 2019
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/204818 mentions this issue: internal/lsp/cmd: re-enable the definition cmd tests

@heschi
Copy link
Contributor

heschi commented Sep 25, 2020

TestDefinitionHelpExample in cmd_test.go references this bug, and fixing it wasn't totally trivial. Reopening for a decision.

@heschi heschi reopened this Sep 25, 2020
@stamblerre stamblerre modified the milestones: Unreleased, gopls/v1.0.0 Sep 25, 2020
@stamblerre stamblerre added the Soon This needs action soon. (recent regressions, service outages, unusual time-sensitive situations) label Nov 2, 2020
@stamblerre
Copy link
Contributor Author

I think these tests have been skipped for so long that the code has really diverged. I think it's probably simplest to delete the test.

@gopherbot
Copy link
Contributor

Change https://golang.org/cl/267122 mentions this issue: internal/lsp/cmd: delete TestDefinitionHelpExample test

@golang golang locked and limited conversation to collaborators Nov 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Soon This needs action soon. (recent regressions, service outages, unusual time-sensitive situations) Testing An issue that has been verified to require only test changes, not just a test failure. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
gopls/v0.5.3
Development

No branches or pull requests
4 participants
@dmitshur @stamblerre @gopherbot @heschi