Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Alby Go page doesn't redirect on scanning 1-tap QR #1140

Closed
im-adithya opened this issue Mar 3, 2025 · 4 comments · Fixed by #1148
Closed

Bug: Alby Go page doesn't redirect on scanning 1-tap QR #1140

im-adithya opened this issue Mar 3, 2025 · 4 comments · Fixed by #1148
Assignees
Milestone

Comments

@im-adithya
Copy link
Member

We should redirect to apps page once it's scanned like we do in AppCreated screen.

Image

@rolznz
Copy link
Contributor

rolznz commented Mar 3, 2025

@im-adithya I don't think we always want to redirect (for example the Friends & Family app)

@rolznz
Copy link
Contributor

rolznz commented Mar 3, 2025

Maybe we can render different content on the card instead if we don't do a redirect?)

@rolznz
Copy link
Contributor

rolznz commented Mar 3, 2025

(I think this needs to be reviewed for all usages of ConnectAppCard)

@rolznz rolznz added this to the v1.15.0 milestone Mar 3, 2025
@im-adithya
Copy link
Member Author

Yeah that's why I only mentioned Alby Go

But ig a good solution would be to maybe do a redirect in Alby Go screen and also do something like this for other instances where we don't wish to

Maybe we can render different content on the card instead if we don't do a redirect?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants