Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebuild #187 #209

Merged
merged 2 commits into from
Oct 17, 2020
Merged

Rebuild #187 #209

merged 2 commits into from
Oct 17, 2020

Conversation

cyamonide
Copy link
Collaborator

Description

This PR re-lands #187 by rebuilding files in dist/. Inspecting the build files, this should fix the isPlainObject dependency issues we've been struggling to fix.

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@use-herald-action-app
Copy link

Hi there, given these changes, Herald suggest these users should take a look!
Rule Mention
This is a rule to attach @gagoar when workflow changes @gagoar

@codecov
Copy link

codecov bot commented Oct 17, 2020

Codecov Report

Merging #209 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #209   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            8         8           
  Lines          323       334   +11     
  Branches        41        42    +1     
=========================================
+ Hits           323       334   +11     
Flag Coverage Δ
#unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/comment.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44d9320...02ea15d. Read the comment docs.

@cyamonide cyamonide merged commit 6fb5fdd into gagoar:master Oct 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants