Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding targetURL when using status action #118

Merged
merged 10 commits into from
Sep 8, 2020
Merged

adding targetURL when using status action #118

merged 10 commits into from
Sep 8, 2020

Conversation

gagoar
Copy link
Owner

@gagoar gagoar commented Sep 8, 2020

Issue Reference: fixes #117

Description

This Pr allows you to provide a targetURL that it will be the

Motivation and Context

I thought it will be pretty useful to offer a link on the details that takes you to documentation about that validation or some useful link

How Has This Been Tested?

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@codecov
Copy link

codecov bot commented Sep 8, 2020

Codecov Report

Merging #118 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #118   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            8         8           
  Lines          320       322    +2     
  Branches        57        58    +1     
=========================================
+ Hits           320       322    +2     
Flag Coverage Δ
#unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/rules.ts 100.00% <100.00%> (ø)
src/statuses.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a36bcd5...5f0e21b. Read the comment docs.

Copy link
Collaborator

@cyamonide cyamonide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gagoar gagoar merged commit bb169fe into master Sep 8, 2020
@gagoar gagoar deleted the gg/issue_117 branch September 8, 2020 05:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add option to provide a targetURL when using status action
2 participants