Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding pull_request_target #103

Merged
merged 2 commits into from
Aug 28, 2020
Merged

Adding pull_request_target #103

merged 2 commits into from
Aug 28, 2020

Conversation

gagoar
Copy link
Owner

@gagoar gagoar commented Aug 27, 2020

Issue Reference: fixes #102

Description

pull_request_target is a logical addition given that GitHub has recently added this event to deal with forks PRing to a base repo.

Motivation and Context

we need to support any form of PR action.

How Has This Been Tested?

unit tests.

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@gagoar gagoar requested a review from cyamonide August 27, 2020 23:59
@github-actions
Copy link

Thanks for contributing!. The pull request description looks good. Please give us some time to review!

@codecov
Copy link

codecov bot commented Aug 28, 2020

Codecov Report

Merging #103 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #103   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            6         6           
  Lines          266       266           
  Branches        48        48           
=========================================
  Hits           266       266           
Flag Coverage Δ
#unittests 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c106380...19e1b54. Read the comment docs.

@gagoar gagoar changed the title adding pull_request_target Adding pull_request_target Aug 28, 2020
@gagoar gagoar merged commit f4ef4d8 into master Aug 28, 2020
@gagoar gagoar deleted the gg/issue_#102 branch August 28, 2020 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable pull_request_target
2 participants