fix: address comments from vrs 2.0.0 community review ballot #623
+78
−84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
korikuzma
commented
Jan 8, 2025
Comment on lines
+6
to
+7
| VRS currently covers many classes of variation that are defined on multiple molecules | ||
| in the context of a system, e.g. a genome, sample, or homologous chromosomes. |
There was a problem hiding this comment.
@ahwagner @larrybabb can you provide with alternative sentence (or else it will show up twice)
There was a problem hiding this comment.
?? what will show up twice?
larrybabb
reviewed
Feb 10, 2025
There was a problem hiding this comment.
@korikuzma I included almost all of these changes in the recent 2.x PR. The changes to the .rst files within the schema/vrs/def folders are "off limits unless they are done by MSP. I'm guessing that you made these manually, because when I reran with MSP it put the gks-core:Entity back in. I was able to fix by adding an extra reference in the docs/**/.rst files to allow these :ref:s to resolve.
|
@korikuzma after you review my forthcoming PR on 2.x updates, we should close this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses some comments from #605