-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed autocorr + Lempel Ziv Complexity + Some failing tests #67
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just renamed value
to threshold
changed to threshold Co-authored-by: Chris Lo <[email protected]>
Co-authored-by: Chris Lo <[email protected]>
Co-authored-by: Chris Lo <[email protected]>
@MathieuCayssol Autocorrelation should be correct now. Please take a look |
Sure, I will have a look. For the unit tests, the things you've updated, I already did it in the branch #66 |
Co-authored-by: Chris Lo <[email protected]>
The issue is that in lazy Polars, slice behaves differently. The problem lies somewhere in its length calculation. Try running the following code, which will give us error in the lazy case. Since in our original code, we are just returning one expression at the end, the error didn't occur, but something inside was wrong. You can see the issue here: pola-rs/polars#11594 (comment)
I fixed the bug by reverting back to using shift, which will be slower than .head() / tail() / slice(), but will avoid using slice for now. We actually do not need to drop nulls after shifting, because dot product will null will just result in 0.