Add kernel, global, and timeout flags #334
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've been using
flamegraph
for full-system benchmarking at Oxide, relying heavily on custom sampling commands (since it only samples one process by default). This PR would let us stop using custom commands by adding their functionality into the mainflamegraph
executable:--kernel
changes the flamegraph probe to also capture kernel stack frames--global
captures a flamegraph of everything in the system, instead of a single process--timeout
tellsflamegraph
to exit after a certain amount of time, e.g. to capture 1 second of full-system tracesThe results are pretty neat:
I have only implemented these flags for the DTrace backend, but
perf
will print helpful error messages if you try to use them. If you want to maintain strict CLI parity, let me know and I can dig into whatperf
changes would be required.