Skip to content

Commit f1488db

Browse files
kelsetfacebook-github-bot
authored andcommitted
bump Node references from 12/14 to 14/16 (#32980)
Summary: Node 16 has been the LTS for quite some time now ([Oct 2021](https://nodejs.org/en/blog/release/v16.13.0/)), so this PR just wants to bring the RN OSS CI up to speed. (I realized that this was needed while doing the same for macos microsoft#997) ## Changelog <!-- Help reviewers and the release process by writing your own changelog entry. For an example, see: https://github.com/facebook/react-native/wiki/Changelog --> [General] [Changed] - CI moved to Node 16. Pull Request resolved: #32980 Test Plan: CI itself is the test � locally no significant changes were experienced. Reviewed By: cortinico Differential Revision: D33821288 Pulled By: ShikaSD fbshipit-source-id: 4480ae1cb909e2b8d0b6abba4db76bbe71f0193e
1 parent b3c69e8 commit f1488db

File tree

3 files changed

+8
-8
lines changed

3 files changed

+8
-8
lines changed

.circleci/config.yml

+6-6
Original file line numberDiff line numberDiff line change
@@ -28,11 +28,11 @@ executors:
2828
<<: *defaults
2929
docker:
3030
# Note: Version set separately for Windows builds, see below.
31-
- image: circleci/node:14
31+
- image: circleci/node:16
3232
nodeprevlts:
3333
<<: *defaults
3434
docker:
35-
- image: circleci/node:12
35+
- image: circleci/node:14
3636
reactnativeandroid:
3737
<<: *defaults
3838
docker:
@@ -376,7 +376,7 @@ jobs:
376376
- run:
377377
name: Configure Environment Variables
378378
command: |
379-
echo 'export PATH=/usr/local/opt/node@14/bin:$PATH' >> $BASH_ENV
379+
echo 'export PATH=/usr/local/opt/node@16/bin:$PATH' >> $BASH_ENV
380380
source $BASH_ENV
381381
382382
- with_brew_cache_span:
@@ -393,7 +393,7 @@ jobs:
393393
name: Configure Node
394394
# Sourcing find-node.sh will ensure nvm is set up.
395395
# It also helps future invocation of find-node.sh prevent permission issue with nvm.sh.
396-
command: source scripts/find-node.sh && nvm install 14 && nvm alias default 14
396+
command: source scripts/find-node.sh && nvm install 16 && nvm alias default 16
397397

398398
- run:
399399
name: Configure Watchman
@@ -644,8 +644,8 @@ jobs:
644644
name: Install Node
645645
# Note: Version set separately for non-Windows builds, see above.
646646
command: |
647-
nvm install 14.17.0
648-
nvm use 14.17.0
647+
nvm install 16
648+
nvm use 16
649649
650650
# Setup Dependencies
651651
- run:

package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
"license": "MIT",
88
"repository": "github:facebook/react-native",
99
"engines": {
10-
"node": ">=12"
10+
"node": ">=14"
1111
},
1212
"jest-junit": {
1313
"outputDirectory": "reports/junit",

scripts/validate-ios-test-env.sh

+1-1
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ fi
2323
# Check that the correct version of node is installed
2424
NODE_VERSION="$(command node --version | sed 's/[-/a-zA-Z]//g' |sed 's/.\{2\}$//')"
2525

26-
if (( $(echo "${NODE_VERSION} < 12.0" | bc -l) )); then
26+
if (( $(echo "${NODE_VERSION} < 14.0" | bc -l) )); then
2727
echo "Node ${NODE_VERSION} detected. This version of Node is not supported."
2828
echo "See https://reactnative.dev/docs/getting-started for instructions."
2929
exit 1

0 commit comments

Comments
 (0)