Skip to content

Commit e5a8f42

Browse files
Simekfacebook-github-bot
authored andcommitted
fix StatusBar showHideTransition flow type issue (#29034)
Summary: This small PR adds third, missing [`StatusBarAnimation`](https://github.com/facebook/react-native/blob/master/Libraries/Components/StatusBar/StatusBar.js#L45) possible value to the `showHideTransition` prop validation - `'none'`. This fixes the following issue when `<StatusBar showHideTransition="none" />` code is used: <img width="970" alt="Screenshot 2020-06-02 at 22 39 37" src="https://user-images.githubusercontent.com/719641/83567510-f6b85200-a521-11ea-9f1c-48825d0285bf.png"> ## Changelog <!-- Help reviewers and the release process by writing your own changelog entry. For an example, see: https://github.com/facebook/react-native/wiki/Changelog --> [iOS] [Fixed] - fix StatusBar showHideTransition flow type issue Pull Request resolved: #29034 Test Plan: I have run the `flow` check in the test project which uses local working copy of `react-native` with this change included. Reviewed By: GijsWeterings Differential Revision: D22493825 Pulled By: cpojer fbshipit-source-id: 463badec67e6725cb8711a79aa43d84f9b09f796
1 parent 1c634a9 commit e5a8f42

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

Libraries/Components/StatusBar/StatusBar.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ type IOSProps = $ReadOnly<{|
8787
*
8888
* @platform ios
8989
*/
90-
showHideTransition?: ?('fade' | 'slide'),
90+
showHideTransition?: ?('fade' | 'slide' | 'none'),
9191
|}>;
9292

9393
type Props = $ReadOnly<{|

0 commit comments

Comments
 (0)