Skip to content

Commit da7d3df

Browse files
hramosfacebook-github-bot
authored andcommitted
Partially back out #24506, fixing iOS e2e tests (#24788)
Summary: The iOS End-to-End tests started failing with the updates made to the iOS template's Podfile in 261197d. Undoing these gets our CI iOS e2e test step back to green. [iOS] [Removed] - Revert auto-linking related changes to the iOS template Podfile Pull Request resolved: #24788 Differential Revision: D15317895 Pulled By: cpojer fbshipit-source-id: a1f3b84b39c6d341740f742d83fd05a1ab841184
1 parent 0245fd7 commit da7d3df

File tree

2 files changed

+12
-4
lines changed

2 files changed

+12
-4
lines changed

.circleci/config.yml

+12-2
Original file line numberDiff line numberDiff line change
@@ -499,12 +499,22 @@ jobs:
499499

500500
- run:
501501
name: Run JavaScript End-to-End Tests
502-
command: node ./scripts/run-ci-e2e-tests.js --js --retries 3
502+
command: |
503+
# free up port 8081 for the packager before running tests
504+
set +eo pipefail
505+
lsof -i tcp:8081 | awk 'NR!=1 {print $2}' | xargs kill
506+
set -eo pipefail
507+
node ./scripts/run-ci-e2e-tests.js --js --retries 3
503508
when: always
504509

505510
- run:
506511
name: Run iOS End-to-End Tests
507-
command: node ./scripts/run-ci-e2e-tests.js --ios --retries 3;
512+
command: |
513+
# free up port 8081 for the packager before running tests
514+
set +eo pipefail
515+
lsof -i tcp:8081 | awk 'NR!=1 {print $2}' | xargs kill
516+
set -eo pipefail
517+
node ./scripts/run-ci-e2e-tests.js --ios --retries 3;
508518
when: always
509519

510520

template/ios/Podfile

-2
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
platform :ios, '9.0'
2-
require_relative '../node_modules/@react-native-community/cli-platform-ios/native_modules'
32

43
target 'HelloWorld' do
54
# Pods for HelloWorld
@@ -33,7 +32,6 @@ target 'HelloWorld' do
3332
# Pods for testing
3433
end
3534

36-
use_native_modules!
3735
end
3836

3937
target 'HelloWorld-tvOS' do

0 commit comments

Comments
 (0)