Don't return empty string for accessibilityLabel for RCTView

sammy-SC · facebook-github-bot · commit d4ff5ed258b7 · 2019-05-20T01:40:52.000-07:00
Summary: In case `RCTView` had no subviews, `RCTRecursiveAccessibilityLabel` was returning an empty string rather than nil. I've noticed that https://fburl.com/i95iynxi returns empty string as well. Shall we change it there as well? Reviewed By: shergin Differential Revision: D15337865 fbshipit-source-id: 8e38a88321f3dcfdf35a38d43fdbe4f5118796f1
diff --git a/React/Views/RCTView.m b/React/Views/RCTView.m
@@ -95,7 +95,7 @@ - (UIView *)react_findClipView
       [str appendString:label];
     }
   }
-  return str;
+  return str.length == 0 ? nil : str;
 }
 
 @implementation RCTView

Original file line number	Diff line number	Diff line change
`@@ -95,7 +95,7 @@ - (UIView *)react_findClipView`
`95`	`95`	`[str appendString:label];`
`96`	`96`	`}`
`97`	`97`	`}`
`98`		`- return str;`
	`98`	`+ return str.length == 0 ? nil : str;`
`99`	`99`	`}`
`100`	`100`
`101`	`101`	`@implementation RCTView`