Skip to content

Commit c4c34a1

Browse files
RSNarafacebook-github-bot
authored andcommitted
Delete RCTTurboModuleManagerDelegate getTurboModule:initParams
Summary: D27316129 made it mandatory for all RCTTurboModules to have a getTurboModule: method. So, there's no need to keep the getTurboModule:initParams method in RCTTurboModuleManagerDelegate. So, to simplify the TurboModule infra, this diff gets rid of that TurboModuleManager delegate method. Changelog: [iOS][Removed] - Delete RCTTurboModuleManagerDelegate getTurboModule:initParams Reviewed By: fkgozali Differential Revision: D27316873 fbshipit-source-id: c0b8449c6088bf08f17ba9a8d1c2cb644e5a242d
1 parent e0b8f50 commit c4c34a1

File tree

4 files changed

+0
-28
lines changed

4 files changed

+0
-28
lines changed

ReactCommon/react/nativemodule/core/platform/ios/RCTTurboModuleManager.h

-6
Original file line numberDiff line numberDiff line change
@@ -15,16 +15,10 @@
1515

1616
@protocol RCTTurboModuleManagerDelegate <NSObject>
1717

18-
// TODO: Move to xplat codegen.
19-
- (std::shared_ptr<facebook::react::TurboModule>)getTurboModule:(const std::string &)name
20-
initParams:
21-
(const facebook::react::ObjCTurboModule::InitParams &)params;
2218
@optional
2319
- (NSArray<NSString *> *)getEagerInitModuleNames;
2420
- (NSArray<NSString *> *)getEagerInitMainQueueModuleNames;
2521

26-
@optional
27-
2822
/**
2923
* Given a module name, return its actual class. If not provided, basic ObjC class lookup is performed.
3024
*/

packages/rn-tester/RNTester/AppDelegate.mm

-7
Original file line numberDiff line numberDiff line change
@@ -204,13 +204,6 @@ - (Class)getModuleClassFromName:(const char *)name
204204
return facebook::react::RNTesterTurboModuleProvider(name, jsInvoker);
205205
}
206206

207-
- (std::shared_ptr<facebook::react::TurboModule>)getTurboModule:(const std::string &)name
208-
initParams:
209-
(const facebook::react::ObjCTurboModule::InitParams &)params
210-
{
211-
return facebook::react::RNTesterTurboModuleProvider(name, params);
212-
}
213-
214207
- (id<RCTTurboModule>)getModuleInstanceFromClass:(Class)moduleClass
215208
{
216209
if (moduleClass == RCTImageLoader.class) {

packages/rn-tester/RNTester/RNTesterTurboModuleProvider.h

-6
Original file line numberDiff line numberDiff line change
@@ -20,11 +20,5 @@ Class RNTesterTurboModuleClassProvider(const char *name);
2020
*/
2121
std::shared_ptr<TurboModule> RNTesterTurboModuleProvider(const std::string &name, std::shared_ptr<CallInvoker> jsInvoker);
2222

23-
/**
24-
* Provide an instance of a ObjCTurboModule, given the ObjC instance, specific to this app.
25-
*/
26-
std::shared_ptr<TurboModule> RNTesterTurboModuleProvider(const std::string &name,
27-
const ObjCTurboModule::InitParams &params);
28-
2923
} // namespace react
3024
} // namespace facebook

packages/rn-tester/RNTester/RNTesterTurboModuleProvider.mm

-9
Original file line numberDiff line numberDiff line change
@@ -28,14 +28,5 @@ Class RNTesterTurboModuleClassProvider(const char *name) {
2828
return nullptr;
2929
}
3030

31-
std::shared_ptr<TurboModule> RNTesterTurboModuleProvider(const std::string &name,
32-
const ObjCTurboModule::InitParams &params) {
33-
if (name == "SampleTurboModule") {
34-
return std::make_shared<NativeSampleTurboModuleSpecJSI>(params);
35-
}
36-
37-
return nullptr;
38-
}
39-
4031
} // namespace react
4132
} // namespace facebook

0 commit comments

Comments
 (0)