Remove unnecessary packager running check when saved JSLocation is empty

jimmy623 · facebook-github-bot · commit bbb7bef539f4 · 2020-07-21T09:55:11.000-07:00
Summary:
Changelog:
When the JSLocation is nil, checking whether the address is running is unnesarry and wasting time, adding a JSLocation length check to mitigate that.

Reviewed By: cpojer

Differential Revision: D22644574

fbshipit-source-id: c51fc1a8976ebc25cba2653581e1bfa479a1d70d
diff --git a/React/Base/RCTBundleURLProvider.mm b/React/Base/RCTBundleURLProvider.mm
@@ -126,7 +126,7 @@ - (NSString *)packagerServerHost
 {
   NSString *location = [self jsLocation];
 #if RCT_DEV_MENU
-  if (![RCTBundleURLProvider isPackagerRunning:location]) {
+  if ([location length] && ![RCTBundleURLProvider isPackagerRunning:location]) {
     location = nil;
   }
 #endif

Original file line number	Diff line number	Diff line change
`@@ -126,7 +126,7 @@ - (NSString *)packagerServerHost`
`126`	`126`	`{`
`127`	`127`	`NSString *location = [self jsLocation];`
`128`	`128`	`#if RCT_DEV_MENU`
`129`		`- if (![RCTBundleURLProvider isPackagerRunning:location]) {`
	`129`	`+ if ([location length] && ![RCTBundleURLProvider isPackagerRunning:location]) {`
`130`	`130`	`location = nil;`
`131`	`131`	`}`
`132`	`132`	`#endif`