Skip to content

Commit b8621f5

Browse files
willholenfacebook-github-bot
authored andcommitted
Try the debug executor before the release executor
Summary: We are currently unintentionally including both libhermes-executor-release.so and libhermes-executor-debug.so in all OSS RN builds. RN tries both in turn, but since they both exist and the release executor is compatible with the debug build, we always get the release executor without debug functionality. While we sort this out, switch the load order. Since the debug executor is not compatible with the release build, so it'll fail to load and try the next one. ChangeLog: [Android] Fix Hermes debugger being disabled by default Reviewed By: mhorowitz Differential Revision: D20163828 fbshipit-source-id: ee4d87f40e42a7c8eedfdb7e1fc17eb3e5966ba5
1 parent 06b8b15 commit b8621f5

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

ReactAndroid/src/main/java/com/facebook/hermes/reactexecutor/HermesExecutor.java

+3-3
Original file line numberDiff line numberDiff line change
@@ -19,11 +19,11 @@ public class HermesExecutor extends JavaScriptExecutor {
1919
// libhermes must be loaded explicitly to invoke its JNI_OnLoad.
2020
SoLoader.loadLibrary("hermes");
2121
try {
22-
SoLoader.loadLibrary("hermes-executor-release");
23-
mode_ = "Release";
24-
} catch (UnsatisfiedLinkError e) {
2522
SoLoader.loadLibrary("hermes-executor-debug");
2623
mode_ = "Debug";
24+
} catch (UnsatisfiedLinkError e) {
25+
SoLoader.loadLibrary("hermes-executor-release");
26+
mode_ = "Release";
2727
}
2828
}
2929

0 commit comments

Comments
 (0)