Delete concept of live reloading

Summary:
Live reloading has been deprecated in favor of fast refresh for years, this diff removes remaining references to it.

Changelog: [iOS] Delete deprecated "live reloading" setting

Reviewed By: fkgozali

Differential Revision: D26983596

fbshipit-source-id: c7f86e7ec511f80e53659bccd8f40ac4f0cac27c

Author: Peter Argany

React/Base/RCTBundleURLProvider.h

@@ -96,8 +96,6 @@ extern const NSUInteger kRCTBundleURLProviderDefaultPort;
  * The IP address or hostname of the packager.
  */
 @property (nonatomic, copy) NSString *jsLocation;
-
-@property (nonatomic, assign) BOOL enableLiveReload;
 @property (nonatomic, assign) BOOL enableMinification;
 @property (nonatomic, assign) BOOL enableDev;
 

React/Base/RCTBundleURLProvider.mm

@@ -15,9 +15,6 @@
 const NSUInteger kRCTBundleURLProviderDefaultPort = RCT_METRO_PORT;
 
 static NSString *const kRCTJsLocationKey = @"RCT_jsLocation";
-// This option is no longer exposed in the dev menu UI.
-// It was renamed in D15958697 so it doesn't get stuck with no way to turn it off:
-static NSString *const kRCTEnableLiveReloadKey = @"RCT_enableLiveReload_LEGACY";
 static NSString *const kRCTEnableDevKey = @"RCT_enableDev";
 static NSString *const kRCTEnableMinificationKey = @"RCT_enableMinification";
 
@@ -35,7 +32,6 @@ - (instancetype)init
 - (NSDictionary *)defaults
 {
   return @{
-    kRCTEnableLiveReloadKey : @NO,
     kRCTEnableDevKey : @YES,
     kRCTEnableMinificationKey : @NO,
   };
@@ -275,11 +271,6 @@ - (BOOL)enableDev
   return [[NSUserDefaults standardUserDefaults] boolForKey:kRCTEnableDevKey];
 }
 
-- (BOOL)enableLiveReload
-{
-  return [[NSUserDefaults standardUserDefaults] boolForKey:kRCTEnableLiveReloadKey];
-}
-
 - (BOOL)enableMinification
 {
   return [[NSUserDefaults standardUserDefaults] boolForKey:kRCTEnableMinificationKey];
@@ -295,11 +286,6 @@ - (void)setEnableDev:(BOOL)enableDev
   [self updateValue:@(enableDev) forKey:kRCTEnableDevKey];
 }
 
-- (void)setEnableLiveReload:(BOOL)enableLiveReload
-{
-  [self updateValue:@(enableLiveReload) forKey:kRCTEnableLiveReloadKey];
-}
-
 - (void)setJsLocation:(NSString *)jsLocation
 {
   [self updateValue:jsLocation forKey:kRCTJsLocationKey];

React/CoreModules/RCTDevMenu.h

@@ -34,11 +34,6 @@ RCT_EXTERN NSString *const RCTShowDevMenuNotification;
  */
 @property (nonatomic, assign) BOOL profilingEnabled DEPRECATED_ATTRIBUTE;
 
-/**
- * Deprecated, use RCTDevSettings instead.
- */
-@property (nonatomic, assign) BOOL liveReloadEnabled DEPRECATED_ATTRIBUTE;
-
 /**
  * Deprecated, use RCTDevSettings instead.
  */