Skip to content

Commit b4c9f13

Browse files
doniwinata0309facebook-github-bot
authored andcommitted
Remove Okhttp3 Android Proguard Rules (#30514)
Summary: Remove proguard keep rules on okhttp3. The library already contains its own consumer proguard --> see https://square.github.io/okhttp/r8_proguard/ The keep rules will increase the final apk size of android app. Currently, there is no way to disable proguard rules from transitive dependencies ( https://issuetracker.google.com/issues/37073777). So any android app that use react native will also contains this proguard rules. ## Changelog [Android] [Removed] - Remove okhttp3 proguard rules Pull Request resolved: #30514 Test Plan: n/a Reviewed By: mdvacca Differential Revision: D25616704 Pulled By: fkgozali fbshipit-source-id: eb0bcbc4ace398a55ce6902e34c17b030bb87130
1 parent 8c8172f commit b4c9f13

File tree

1 file changed

+0
-7
lines changed

1 file changed

+0
-7
lines changed

ReactAndroid/proguard-rules.pro

-7
Original file line numberDiff line numberDiff line change
@@ -55,13 +55,6 @@
5555
# hermes
5656
-keep class com.facebook.jni.** { *; }
5757

58-
# okhttp
59-
60-
-keepattributes Signature
61-
-keepattributes *Annotation*
62-
-keep class okhttp3.** { *; }
63-
-keep interface okhttp3.** { *; }
64-
-dontwarn okhttp3.**
6558

6659
# okio
6760

0 commit comments

Comments
 (0)