Skip to content

Commit ab8dbdf

Browse files
KDederichsfacebook-github-bot
authored andcommitted
Disable gflags include (#28451)
Summary: Fixes the issue explained in #28446 It basically disabled the gflags include before configure can detect the header on the users system. ## Changelog [iOS] [Fixed] - Fixed inability to build apps when gflags is installed Pull Request resolved: #28451 Test Plan: Tested by installing gflags `brew install gflags` and verifying that apps build after. Reviewed By: javache Differential Revision: D30345352 Pulled By: sota000 fbshipit-source-id: 04c98d7ddebe6708057407c4b4bf3701434822a3
1 parent c807b69 commit ab8dbdf

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

scripts/ios-configure-glog.sh

+4
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,10 @@ if [ -h "test-driver" ]; then
2828
rm test-driver
2929
fi
3030

31+
# Manually disable gflags include to fix issue https://github.com/facebook/react-native/issues/28446
32+
sed -i '' 's/\@ac_cv_have_libgflags\@/0/' src/glog/logging.h.in
33+
sed -i '' 's/HAVE_LIB_GFLAGS/HAVE_LIB_GFLAGS_DISABLED/' src/config.h.in
34+
3135
./configure --host arm-apple-darwin
3236

3337
cat << EOF >> src/config.h

0 commit comments

Comments
 (0)