Fix typo in Value's constructor with a Symbol

jpporto · facebook-github-bot · commit a7a0f86a73ab · 2022-04-17T11:53:12.000-07:00
Summary:
The current JSI implementation is converting a Symbol to String when creating a jsi Value.

Changelog: [General][Fixed]

Reviewed By: neildhar

Differential Revision: D35705825

fbshipit-source-id: 3bee0a02bb77643c6a33031b4d98ac9a7e126303
diff --git a/ReactCommon/jsi/jsi/jsi.h b/ReactCommon/jsi/jsi/jsi.h
@@ -992,7 +992,7 @@ class JSI_EXPORT Value {
 
   /// Copies a Symbol lvalue into a new JS value.
   Value(Runtime& runtime, const Symbol& sym) : Value(SymbolKind) {
-    new (&data_.pointer) String(runtime.cloneSymbol(sym.ptr_));
+    new (&data_.pointer) Symbol(runtime.cloneSymbol(sym.ptr_));
   }
 
   /// Copies a String lvalue into a new JS value.

Original file line number	Diff line number	Diff line change
`@@ -992,7 +992,7 @@ class JSI_EXPORT Value {`
`992`	`992`
`993`	`993`	`/// Copies a Symbol lvalue into a new JS value.`
`994`	`994`	`Value(Runtime& runtime, const Symbol& sym) : Value(SymbolKind) {`
`995`		`- new (&data_.pointer) String(runtime.cloneSymbol(sym.ptr_));`
	`995`	`+ new (&data_.pointer) Symbol(runtime.cloneSymbol(sym.ptr_));`
`996`	`996`	`}`
`997`	`997`
`998`	`998`	`/// Copies a String lvalue into a new JS value.`