Skip to content

Commit 9e7d91f

Browse files
danilobuergerfacebook-github-bot
authored andcommitted
Re-apply: Consider relative to pwd installation root when looking for files in rn module via cocoapods (#33427)
Summary: This re-applies Consider relative to pwd installation root when looking for files in rn module via cocoapods by danilobuerger The `:reactNativePath` provided by `use_native_modules!` is the rn module path relative to the installation root (usually `./ios`). However, when executing cocoapods from a dir thats not the installation root, packages that use the relative `:reactNativePath` variable in their path must also consider the relative to pwd installation root. This fixes usage of cocoapods with the `--project-directory` flag like ```bash bundle exec pod install --project-directory=ios ``` ## Changelog [iOS] [Fixed] - Fix usage of cocoapods with --project-directory flag and new arch Pull Request resolved: #33427 Test Plan: 1) Enable the new arch 2) Execute from the projects root dir ```bash bundle exec pod install --project-directory=ios ``` 3) It will fail with ``` [!] Invalid `Podfile` file: [codegen] Couldn't not find react-native-codegen.. ``` 4) Apply the patch 5) Execute from the projects root dir ```bash bundle exec pod install --project-directory=ios ``` 6) It will succeed Reviewed By: cortinico Differential Revision: D34890926 Pulled By: dmitryrykun fbshipit-source-id: f7adc6196874822d5ff38f275414f529d385f2ea
1 parent 10d2e4c commit 9e7d91f

File tree

2 files changed

+8
-6
lines changed

2 files changed

+8
-6
lines changed

scripts/react_native_pods.rb

+6-4
Original file line numberDiff line numberDiff line change
@@ -278,8 +278,9 @@ def modify_flags_for_new_architecture(installer, cpp_flags)
278278
end
279279

280280
def build_codegen!(react_native_path)
281-
codegen_repo_path = "#{react_native_path}/packages/react-native-codegen";
282-
codegen_npm_path = "#{react_native_path}/../react-native-codegen";
281+
relative_installation_root = Pod::Config.instance.installation_root.relative_path_from(Pathname.pwd)
282+
codegen_repo_path = "#{relative_installation_root}/#{react_native_path}/packages/react-native-codegen";
283+
codegen_npm_path = "#{relative_installation_root}/#{react_native_path}/../react-native-codegen";
283284
codegen_cli_path = ""
284285
if Dir.exist?(codegen_repo_path)
285286
codegen_cli_path = codegen_repo_path
@@ -320,7 +321,7 @@ def checkAndGenerateEmptyThirdPartyProvider!(react_native_path)
320321
Pod::Executable.execute_command(
321322
'node',
322323
[
323-
"#{react_native_path}/scripts/generate-provider-cli.js",
324+
"#{relative_installation_root}/#{react_native_path}/scripts/generate-provider-cli.js",
324325
"--platform", 'ios',
325326
"--schemaListPath", temp_schema_list_path,
326327
"--outputDir", "#{output_dir}"
@@ -510,6 +511,7 @@ def use_react_native_codegen_discovery!(options={})
510511
app_path = options[:app_path]
511512
fabric_enabled = options[:fabric_enabled] ||= false
512513
config_file_dir = options[:config_file_dir] ||= ''
514+
relative_installation_root = Pod::Config.instance.installation_root.relative_path_from(Pathname.pwd)
513515

514516
if !app_path
515517
Pod::UI.warn '[Codegen] Error: app_path is required for use_react_native_codegen_discovery.'
@@ -525,7 +527,7 @@ def use_react_native_codegen_discovery!(options={})
525527
out = Pod::Executable.execute_command(
526528
'node',
527529
[
528-
"#{react_native_path}/scripts/generate-artifacts.js",
530+
"#{relative_installation_root}/#{react_native_path}/scripts/generate-artifacts.js",
529531
"-p", "#{app_path}",
530532
"-o", Pod::Config.instance.installation_root,
531533
"-e", "#{fabric_enabled}",

template/ios/Podfile

+2-2
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,8 @@ target 'HelloWorld' do
1515
# to enable hermes on iOS, change `false` to `true` and then install pods
1616
:hermes_enabled => flags[:hermes_enabled],
1717
:fabric_enabled => flags[:fabric_enabled],
18-
# An abosolute path to your application root.
19-
:app_path => "#{Dir.pwd}/.."
18+
# An absolute path to your application root.
19+
:app_path => "#{Pod::Config.instance.installation_root}/.."
2020
)
2121

2222
target 'HelloWorldTests' do

0 commit comments

Comments
 (0)