Skip to content

Commit 9d2df5b

Browse files
liamjonesfacebook-github-bot
authored andcommitted
Fix for iOS displaying a RedBox for LogBox handled errors (#32641)
Summary: Fix for iOS displaying a RedBox for LogBox handled errors, this has been happening since RN 0.65 (in 64.2 and earlier, if it was handled by LogBox then it wouldn't trigger RedBox) Fixes #32106 ## Changelog [iOS] [Fixed] - Stop RedBox from appearing for LogBox handled errors Pull Request resolved: #32641 Test Plan: Manually tested. Seems to fix things (and RedBox still displays for things like 'Could not connect to development server') but I would appreciate RSNara or someone else who is more familiar with the code to confirm that the original switch was a mistake and not something deliberately changed. Reviewed By: christophpurrer Differential Revision: D33661481 Pulled By: cortinico fbshipit-source-id: c9c262adb3f977ae3f13beb9575d3eaa2445f663
1 parent 3a07dcf commit 9d2df5b

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

React/CoreModules/RCTExceptionsManager.mm

+1-1
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ - (void)reportFatal:(NSString *)message stack:(NSArray<NSDictionary *> *)stack e
9191
: (double)exceptionId)
9292
{
9393
RCTRedBox *redbox = [_moduleRegistry moduleForName:"RedBox"];
94-
[redbox showErrorMessage:message withStack:stack errorCookie:(int)exceptionId];
94+
[redbox updateErrorMessage:message withStack:stack errorCookie:(int)exceptionId];
9595

9696
if (_delegate && [_delegate respondsToSelector:@selector(updateJSExceptionWithMessage:stack:exceptionId:)]) {
9797
[_delegate updateJSExceptionWithMessage:message stack:stack exceptionId:[NSNumber numberWithDouble:exceptionId]];

0 commit comments

Comments
 (0)