Skip to content

Commit 9731986

Browse files
mdvaccafacebook-github-bot
authored andcommitted
Upgrade react-native-github Android to support API level 19+
Summary: This diff upgrades react-native-github Android to support API level 19+ changelog: [Android][Deprecated] Deprecate support of Android API levels 16 to 18. The new minSDK version will be 19+ moving forward Reviewed By: JoshuaGross Differential Revision: D22734208 fbshipit-source-id: b052721c8cfb44f8d74cf4bbb5b7a769e544d1d9
1 parent d48f7ba commit 9731986

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

RNTester/android/app/build.gradle

+1-1
Original file line numberDiff line numberDiff line change
@@ -121,7 +121,7 @@ android {
121121

122122
defaultConfig {
123123
applicationId "com.facebook.react.uiapp"
124-
minSdkVersion 18
124+
minSdkVersion 19
125125
targetSdkVersion 29
126126
versionCode 1
127127
versionName "1.0"

ReactAndroid/build.gradle

+3-3
Original file line numberDiff line numberDiff line change
@@ -166,7 +166,7 @@ task prepareJSC {
166166
def jscPackagePath = findNodeModulePath(projectDir, "jsc-android")
167167
if (!jscPackagePath) {
168168
throw new GradleScriptException("Could not find the jsc-android npm package", null)
169-
}
169+
}
170170

171171
def jscDist = file("$jscPackagePath/dist")
172172
if (!jscDist.exists()) {
@@ -223,7 +223,7 @@ task downloadNdkBuildDependencies {
223223
def findNodeModulePath(baseDir, packageName) {
224224
def basePath = baseDir.toPath().normalize()
225225
// Node's module resolution algorithm searches up to the root directory,
226-
// after which the base path will be null
226+
// after which the base path will be null
227227
while (basePath) {
228228
def candidatePath = Paths.get(basePath.toString(), "node_modules", packageName)
229229
if (candidatePath.toFile().exists()) {
@@ -382,7 +382,7 @@ android {
382382
}
383383

384384
defaultConfig {
385-
minSdkVersion(16)
385+
minSdkVersion(19)
386386
targetSdkVersion(28)
387387
versionCode(1)
388388
versionName("1.0")

0 commit comments

Comments
 (0)