Skip to content

Commit 93beb83

Browse files
ryancatfacebook-github-bot
authored andcommitted
Allow overflow scroll to clip the view instead of let it be visible
Summary: When the overflow style set to 'scroll', React ViewGroup does nothing to the container. Instead it should be clipped just like hidden. Changelog: [Android][Changed] - Setting `overflow: scroll` in View component style will clip the children in the View container Reviewed By: javache Differential Revision: D31350605 fbshipit-source-id: e0d618f5e872fec9cf9ecb2d4cfe7af9a2f3c063
1 parent 36f3bf2 commit 93beb83

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

ReactAndroid/src/main/java/com/facebook/react/views/view/ReactViewGroup.java

+1
Original file line numberDiff line numberDiff line change
@@ -786,6 +786,7 @@ private void dispatchOverflowDraw(Canvas canvas) {
786786
}
787787
break;
788788
case ViewProps.HIDDEN:
789+
case ViewProps.SCROLL:
789790
float left = 0f;
790791
float top = 0f;
791792
float right = getWidth();

0 commit comments

Comments
 (0)