Get ReactiveNative compiled with Clang 10 (#28362)

maxovtsin · facebook-github-bot · commit 8721ee0a6b10 · 2020-03-23T13:46:37.000-07:00
Summary: Pull Request resolved: #28362 Fixed a few compilation errors emitted by Clang 10. Changelog: [iOS] [Fixed] - Get ready for Clang 10 Differential Revision: D20549970 fbshipit-source-id: dc36a85d90d3e43a05f045feb57c6ab6ded67da7
diff --git a/React/CxxBridge/RCTCxxBridge.mm b/React/CxxBridge/RCTCxxBridge.mm
@@ -777,7 +777,7 @@ - (void)registerExtraLazyModules
 #endif
 }
 
-- (NSArray<RCTModuleData *> *)_initializeModules:(NSArray<id<RCTBridgeModule>> *)modules
+- (NSArray<RCTModuleData *> *)_initializeModules:(NSArray<Class> *)modules
                                withDispatchGroup:(dispatch_group_t)dispatchGroup
                                 lazilyDiscovered:(BOOL)lazilyDiscovered
 {
diff --git a/ReactCommon/fabric/graphics/platform/ios/Color.cpp b/ReactCommon/fabric/graphics/platform/ios/Color.cpp
@@ -6,6 +6,7 @@
  */
 
 #include "Color.h"
+#include <cassert>
 
 namespace facebook {
 namespace react {
diff --git a/ReactCommon/turbomodule/core/platform/ios/RCTTurboModuleManager.mm b/ReactCommon/turbomodule/core/platform/ios/RCTTurboModuleManager.mm
@@ -308,7 +308,7 @@ - (void)notifyAboutTurboModuleSetup:(const char *)name
             @"%@ has no setter or ivar for its bridge, which is not "
              "permitted. You must either @synthesize the bridge property, "
              "or provide your own setter method.",
-            RCTBridgeModuleNameForClass(strongModule));
+            RCTBridgeModuleNameForClass([strongModule class]));
       }
 
       [performanceLogger attachRCTBridgeToRCTTurboModuleEnd:moduleName];

Original file line number	Diff line number	Diff line change
`@@ -777,7 +777,7 @@ - (void)registerExtraLazyModules`
`777`	`777`	`#endif`
`778`	`778`	`}`
`779`	`779`
`780`		`-- (NSArray<RCTModuleData > )_initializeModules:(NSArray<id<RCTBridgeModule>> *)modules`
	`780`	`+- (NSArray<RCTModuleData > )_initializeModules:(NSArray<Class> *)modules`
`781`	`781`	`withDispatchGroup:(dispatch_group_t)dispatchGroup`
`782`	`782`	`lazilyDiscovered:(BOOL)lazilyDiscovered`
`783`	`783`	`{`
Original file line number	Diff line number	Diff line change
`@@ -308,7 +308,7 @@ - (void)notifyAboutTurboModuleSetup:(const char *)name`
`308`	`308`	`@"%@ has no setter or ivar for its bridge, which is not "`
`309`	`309`	`"permitted. You must either @synthesize the bridge property, "`
`310`	`310`	`"or provide your own setter method.",`
`311`		`- RCTBridgeModuleNameForClass(strongModule));`
	`311`	`+ RCTBridgeModuleNameForClass([strongModule class]));`
`312`	`312`	`}`
`313`	`313`
`314`	`314`	`[performanceLogger attachRCTBridgeToRCTTurboModuleEnd:moduleName];`