Skip to content

Commit 8650220

Browse files
joeframbachfacebook-github-bot
authored andcommitted
Fix ESLint and Typescript-ESLint disagreeing about function spacing (#33453)
Summary: Fixes #33452 by replacing deprecated no-spaced-func ESLint rule and adding related TypeScript. Changelog: [General][Fixed] - Update function spacing linting rules See #33452 - Existing function spacing linting should pass as expected. ## Changelog <!-- Help reviewers and the release process by writing your own changelog entry. For an example, see: https://github.com/facebook/react-native/wiki/Changelog --> [CATEGORY] [TYPE] - Message Pull Request resolved: #33453 Reviewed By: lunaleaps, cortinico Differential Revision: D35011944 Pulled By: GijsWeterings fbshipit-source-id: 441650045d89a01a9114103da0c080643f9cb82c
1 parent 864a8c1 commit 8650220

File tree

1 file changed

+3
-1
lines changed
  • packages/eslint-config-react-native-community

1 file changed

+3
-1
lines changed

packages/eslint-config-react-native-community/index.js

+3-1
Original file line numberDiff line numberDiff line change
@@ -59,6 +59,8 @@ module.exports = {
5959
'no-shadow': 'off',
6060
'@typescript-eslint/no-shadow': 1,
6161
'no-undef': 'off',
62+
'func-call-spacing': 'off',
63+
'@typescript-eslint/func-call-spacing': 1,
6264
},
6365
},
6466
{
@@ -257,7 +259,7 @@ module.exports = {
257259
'no-empty-character-class': 1, // disallow the use of empty character classes in regular expressions
258260
'no-lonely-if': 0, // disallow if as the only statement in an else block (off by default)
259261
'no-new-object': 1, // disallow use of the Object constructor
260-
'no-spaced-func': 1, // disallow space between function identifier and application
262+
'func-call-spacing': 1, // disallow space between function identifier and application
261263
'no-ternary': 0, // disallow the use of ternary operators (off by default)
262264
'no-trailing-spaces': 1, // disallow trailing whitespace at the end of lines
263265
'no-underscore-dangle': 0, // disallow dangling underscores in identifiers

0 commit comments

Comments
 (0)