Skip to content

Commit 812abfd

Browse files
marcmulcahycpojer
authored andcommitted
Fix addition of comma at the end of accessibility labels on Android. (#25963)
1 parent ffdf3f2 commit 812abfd

File tree

1 file changed

+9
-6
lines changed

1 file changed

+9
-6
lines changed

ReactAndroid/src/main/java/com/facebook/react/uimanager/BaseViewManager.java

+9-6
Original file line numberDiff line numberDiff line change
@@ -6,11 +6,14 @@
66
package com.facebook.react.uimanager;
77

88
import android.graphics.Color;
9+
import android.text.TextUtils;
910
import android.view.View;
1011
import android.view.ViewParent;
1112
import androidx.core.view.ViewCompat;
1213

14+
import java.util.ArrayList;
1315
import java.util.HashMap;
16+
import java.util.List;
1417

1518
import com.facebook.react.R;
1619
import com.facebook.react.bridge.ReadableArray;
@@ -173,23 +176,23 @@ private void updateViewContentDescription(@Nonnull T view) {
173176
final String accessibilityLabel = (String) view.getTag(R.id.accessibility_label);
174177
final ReadableArray accessibilityStates = (ReadableArray) view.getTag(R.id.accessibility_states);
175178
final String accessibilityHint = (String) view.getTag(R.id.accessibility_hint);
176-
StringBuilder contentDescription = new StringBuilder();
179+
final List<String> contentDescription = new ArrayList<>();
177180
if (accessibilityLabel != null) {
178-
contentDescription.append(accessibilityLabel + ", ");
181+
contentDescription.add(accessibilityLabel);
179182
}
180183
if (accessibilityStates != null) {
181184
for (int i = 0; i < accessibilityStates.size(); i++) {
182185
String state = accessibilityStates.getString(i);
183186
if (sStateDescription.containsKey(state)) {
184-
contentDescription.append(view.getContext().getString(sStateDescription.get(state)) + ", ");
187+
contentDescription.add(view.getContext().getString(sStateDescription.get(state)));
185188
}
186189
}
187190
}
188191
if (accessibilityHint != null) {
189-
contentDescription.append(accessibilityHint + ", ");
192+
contentDescription.add(accessibilityHint);
190193
}
191-
if (contentDescription.length() > 0) {
192-
view.setContentDescription(contentDescription.toString());
194+
if (contentDescription.size() > 0) {
195+
view.setContentDescription(TextUtils.join(", ", contentDescription));
193196
}
194197
}
195198

0 commit comments

Comments
 (0)