Skip to content

Commit 7b9d6d1

Browse files
makovkastarfacebook-github-bot
authored andcommitted
Bring back JS bundle loading progress bar on Android
Summary: The progress bar on Android was disabled in D5329011 because of T19653381, but was never enabled again. I spent some time trying to reproduce the issue of the bundle being stuck while loading, but didn't succeed. So let's enable the progress bar and monitor whether people would start seeing this bug again. Reviewed By: cpojer Differential Revision: D17148134 fbshipit-source-id: 5130b809460bc743d26a6e88961f81061089fe1d
1 parent d8d3ed5 commit 7b9d6d1

File tree

1 file changed

+1
-5
lines changed

1 file changed

+1
-5
lines changed

ReactAndroid/src/main/java/com/facebook/react/devsupport/BundleDownloader.java

+1-5
Original file line numberDiff line numberDiff line change
@@ -109,11 +109,7 @@ public void downloadBundleFromURL(
109109
final Request request =
110110
requestBuilder
111111
.url(formatBundleUrl(bundleURL))
112-
// FIXME: there is a bug that makes MultipartStreamReader to never find the end of the
113-
// multipart message. This temporarily disables the multipart mode to work around it,
114-
// but
115-
// it means there is no progress bar displayed in the React Native overlay anymore.
116-
// .addHeader("Accept", "multipart/mixed")
112+
.addHeader("Accept", "multipart/mixed")
117113
.build();
118114
mDownloadBundleFromURLCall = Assertions.assertNotNull(mClient.newCall(request));
119115
mDownloadBundleFromURLCall.enqueue(

0 commit comments

Comments
 (0)