Skip to content

Commit 77366cd

Browse files
Luna Weifacebook-github-bot
Luna Wei
authored andcommitted
Remove Picker from OSS
Summary: Changelog: [General][Removed] - Remove Picker code from Android Reviewed By: ShikaSD Differential Revision: D29123164 fbshipit-source-id: 4471ea5f52885735ead07a656452ed5ef2bff65b
1 parent 7f11739 commit 77366cd

34 files changed

+1
-1340
lines changed

ReactAndroid/src/androidTest/java/com/facebook/react/tests/BUCK

-1
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,6 @@ rn_android_library(
3333
react_native_target("java/com/facebook/react/uimanager:uimanager"),
3434
react_native_target("java/com/facebook/react/uimanager/annotations:annotations"),
3535
react_native_target("java/com/facebook/react/uimanager/util:util"),
36-
react_native_target("java/com/facebook/react/views/picker:picker"),
3736
react_native_target("java/com/facebook/react/views/progressbar:progressbar"),
3837
react_native_target("java/com/facebook/react/views/scroll:scroll"),
3938
react_native_target("java/com/facebook/react/views/slider:slider"),

ReactAndroid/src/main/java/com/facebook/react/fabric/jni/Android.mk

+1-2
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ LOCAL_MODULE := fabricjni
1111

1212
LOCAL_SRC_FILES := $(wildcard $(LOCAL_PATH)/*.cpp)
1313

14-
LOCAL_SHARED_LIBRARIES := libreactconfig librrc_slider librrc_progressbar librrc_switch librrc_modal libyoga libglog libfb libfbjni libglog_init libfolly_json libfolly_futures libreact_render_mounting libreactnativeutilsjni libreact_utils libreact_render_debug libreact_render_graphics libreact_render_core react_render_componentregistry librrc_view librrc_unimplementedview librrc_root librrc_scrollview libbetter libreact_render_attributedstring libreact_render_uimanager libreact_render_templateprocessor libreact_render_scheduler libreact_render_animations libreact_render_imagemanager libreact_render_textlayoutmanager libreact_codegen_rncore rrc_text librrc_image librrc_textinput librrc_picker libreact_debug libreact_render_mapbuffer libmapbufferjni libreact_render_telemetry
14+
LOCAL_SHARED_LIBRARIES := libreactconfig librrc_slider librrc_progressbar librrc_switch librrc_modal libyoga libglog libfb libfbjni libglog_init libfolly_json libfolly_futures libreact_render_mounting libreactnativeutilsjni libreact_utils libreact_render_debug libreact_render_graphics libreact_render_core react_render_componentregistry librrc_view librrc_unimplementedview librrc_root librrc_scrollview libbetter libreact_render_attributedstring libreact_render_uimanager libreact_render_templateprocessor libreact_render_scheduler libreact_render_animations libreact_render_imagemanager libreact_render_textlayoutmanager libreact_codegen_rncore rrc_text librrc_image librrc_textinput libreact_debug libreact_render_mapbuffer libmapbufferjni libreact_render_telemetry
1515

1616
LOCAL_STATIC_LIBRARIES :=
1717

@@ -43,7 +43,6 @@ $(call import-module,react/renderer/core)
4343
$(call import-module,react/renderer/components/image)
4444
$(call import-module,react/renderer/components/modal)
4545
$(call import-module,react/renderer/components/root)
46-
$(call import-module,react/renderer/components/picker)
4746
$(call import-module,react/renderer/components/progressbar)
4847
$(call import-module,react/renderer/components/scrollview)
4948
$(call import-module,react/renderer/components/slider)

ReactAndroid/src/main/java/com/facebook/react/fabric/jni/BUCK

-1
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,6 @@ rn_xplat_cxx_library(
4747
"//xplat/js/react-native-github:generated_components-rncore",
4848
react_native_xplat_target("react/renderer/components/image:image"),
4949
react_native_xplat_target("react/renderer/components/modal:modal"),
50-
react_native_xplat_target("react/renderer/components/picker:androidpicker"),
5150
react_native_xplat_target("react/renderer/components/slider:slider"),
5251
react_native_xplat_target("react/renderer/components/switch:androidswitch"),
5352
react_native_xplat_target("react/renderer/components/progressbar:androidprogressbar"),

ReactAndroid/src/main/java/com/facebook/react/fabric/jni/CoreComponentsRegistry.cpp

-6
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,6 @@
1212
#include <fbjni/fbjni.h>
1313

1414
#include <react/renderer/componentregistry/ComponentDescriptorRegistry.h>
15-
#include <react/renderer/components/androidpicker/AndroidDialogPickerComponentDescriptor.h>
16-
#include <react/renderer/components/androidpicker/AndroidDropdownPickerComponentDescriptor.h>
1715
#include <react/renderer/components/androidswitch/AndroidSwitchComponentDescriptor.h>
1816
#include <react/renderer/components/androidtextinput/AndroidTextInputComponentDescriptor.h>
1917
#include <react/renderer/components/image/ImageComponentDescriptor.h>
@@ -71,10 +69,6 @@ CoreComponentsRegistry::sharedProviderRegistry() {
7169
concreteComponentDescriptorProvider<ParagraphComponentDescriptor>());
7270
providerRegistry->add(concreteComponentDescriptorProvider<
7371
AndroidDrawerLayoutComponentDescriptor>());
74-
providerRegistry->add(concreteComponentDescriptorProvider<
75-
AndroidDialogPickerComponentDescriptor>());
76-
providerRegistry->add(concreteComponentDescriptorProvider<
77-
AndroidDropdownPickerComponentDescriptor>());
7872

7973
return providerRegistry;
8074
}();

ReactAndroid/src/main/java/com/facebook/react/shell/BUCK

-1
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,6 @@ rn_android_library(
5555
react_native_target("java/com/facebook/react/views/drawer:drawer"),
5656
react_native_target("java/com/facebook/react/views/image:image"),
5757
react_native_target("java/com/facebook/react/views/modal:modal"),
58-
react_native_target("java/com/facebook/react/views/picker:picker"),
5958
react_native_target("java/com/facebook/react/views/progressbar:progressbar"),
6059
react_native_target("java/com/facebook/react/views/scroll:scroll"),
6160
react_native_target("java/com/facebook/react/views/slider:slider"),

ReactAndroid/src/main/java/com/facebook/react/shell/MainReactPackage.java

-4
Original file line numberDiff line numberDiff line change
@@ -43,8 +43,6 @@
4343
import com.facebook.react.views.drawer.ReactDrawerLayoutManager;
4444
import com.facebook.react.views.image.ReactImageManager;
4545
import com.facebook.react.views.modal.ReactModalHostManager;
46-
import com.facebook.react.views.picker.ReactDialogPickerManager;
47-
import com.facebook.react.views.picker.ReactDropdownPickerManager;
4846
import com.facebook.react.views.progressbar.ReactProgressBarViewManager;
4947
import com.facebook.react.views.scroll.ReactHorizontalScrollContainerViewManager;
5048
import com.facebook.react.views.scroll.ReactHorizontalScrollViewManager;
@@ -160,9 +158,7 @@ public MainReactPackage(MainPackageConfig config) {
160158
public List<ViewManager> createViewManagers(ReactApplicationContext reactContext) {
161159
List<ViewManager> viewManagers = new ArrayList<>();
162160

163-
viewManagers.add(new ReactDialogPickerManager());
164161
viewManagers.add(new ReactDrawerLayoutManager());
165-
viewManagers.add(new ReactDropdownPickerManager());
166162
viewManagers.add(new ReactHorizontalScrollViewManager());
167163
viewManagers.add(new ReactHorizontalScrollContainerViewManager());
168164
viewManagers.add(new ReactProgressBarViewManager());

ReactAndroid/src/main/java/com/facebook/react/viewmanagers/AndroidDialogPickerManagerDelegate.java

-48
This file was deleted.

ReactAndroid/src/main/java/com/facebook/react/viewmanagers/AndroidDialogPickerManagerInterface.java

-23
This file was deleted.

ReactAndroid/src/main/java/com/facebook/react/viewmanagers/AndroidDropdownPickerManagerDelegate.java

-48
This file was deleted.

ReactAndroid/src/main/java/com/facebook/react/viewmanagers/AndroidDropdownPickerManagerInterface.java

-22
This file was deleted.

ReactAndroid/src/main/java/com/facebook/react/views/picker/BUCK

-30
This file was deleted.

ReactAndroid/src/main/java/com/facebook/react/views/picker/ReactDialogPickerManager.java

-51
This file was deleted.

ReactAndroid/src/main/java/com/facebook/react/views/picker/ReactDropdownPickerManager.java

-50
This file was deleted.

0 commit comments

Comments
 (0)