Skip to content

Commit 6b6adcc

Browse files
Kudofacebook-github-bot
authored andcommitted
add back hermes inspector support (#33778)
Summary: the `WITH_INSPECTOR` build flag is missing from cmake migration. original we had it in [Application.mk](https://github.com/facebook/react-native/blob/ed46ea2058b909a2dd401347d68956324961ec2c/ReactAndroid/src/main/jni/Application.mk#L29) this pr adds back the build flag and make hermes inspector (or debugging hermes in flipper) work again. ## Changelog [Android] [Fixed] - add back hermes inspector support Pull Request resolved: #33778 Test Plan: test on rn-tester hermes variant Reviewed By: cipolleschi Differential Revision: D36204525 Pulled By: cortinico fbshipit-source-id: 417874a7d0e05b5ee886f3160d526ff9c2df44ee
1 parent 73a4390 commit 6b6adcc

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

ReactAndroid/src/main/jni/react/jni/CMakeLists.txt

+2-1
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,8 @@ add_compile_options(
1414
-fexceptions
1515
-frtti
1616
-Wno-unused-lambda-capture
17-
-std=c++17)
17+
-std=c++17
18+
-DWITH_INSPECTOR=1)
1819

1920
##########################
2021
### React Native Utils ###

0 commit comments

Comments
 (0)