Skip to content

Commit 6b61995

Browse files
gabrieldonadelfacebook-github-bot
authored andcommitted
build(deps): Bump android Appcompat to 1.4.1 (#33072)
Summary: Currently we are using Appcompat in version 1.0.2 which is almost 4 years old now, this PR updates it to version 1.4.1. Using Appcompat 1.0.2 was also causing a crash on RNTester due to an error where FontFamily's method was not found (Related to #33065) Closes #31620 ## Changelog [Android] [Changed] - Bump android Appcompat to 1.4.1 Pull Request resolved: #33072 Test Plan: Use `./scripts/test-manual-e2e.sh` to test both RNTester and a new app Reviewed By: cortinico Differential Revision: D34107105 Pulled By: ShikaSD fbshipit-source-id: 966e4687b09ae50a88ee518622f073d72e8c6550
1 parent 327c4d7 commit 6b61995

File tree

3 files changed

+19
-5
lines changed

3 files changed

+19
-5
lines changed

ReactAndroid/build.gradle

+2-1
Original file line numberDiff line numberDiff line change
@@ -370,7 +370,8 @@ dependencies {
370370
api("com.facebook.infer.annotation:infer-annotation:0.18.0")
371371
api("com.facebook.yoga:proguard-annotations:1.19.0")
372372
api("javax.inject:javax.inject:1")
373-
api("androidx.appcompat:appcompat:1.0.2")
373+
api("androidx.appcompat:appcompat:${APPCOMPAT_VERSION}")
374+
api("androidx.appcompat:appcompat-resources:${APPCOMPAT_VERSION}")
374375
api("androidx.autofill:autofill:1.1.0")
375376
api("androidx.swiperefreshlayout:swiperefreshlayout:1.0.0")
376377
api("com.facebook.fresco:fresco:${FRESCO_VERSION}")

ReactAndroid/gradle.properties

+1
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ ROBOLECTRIC_VERSION=4.4
1111
JUNIT_VERSION=4.12
1212

1313
ANDROIDX_TEST_VERSION=1.1.0
14+
APPCOMPAT_VERSION=1.4.1
1415
FRESCO_VERSION=2.5.0
1516
OKHTTP_VERSION=4.9.2
1617
SO_LOADER_VERSION=0.10.3

ReactAndroid/src/main/third-party/android/androidx/BUCK

+16-4
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ fb_native.android_library(
1212
exported_deps = [
1313
":annotation",
1414
":appcompat-binary",
15+
":appcompat-resources-binary",
1516
":collection",
1617
":core",
1718
":cursoradapter",
@@ -365,6 +366,11 @@ fb_native.android_prebuilt_aar(
365366
aar = ":appcompat-binary-aar",
366367
)
367368

369+
fb_native.android_prebuilt_aar(
370+
name = "appcompat-resources-binary",
371+
aar = ":appcompat-resources-binary-aar",
372+
)
373+
368374
fb_native.android_prebuilt_aar(
369375
name = "asynclayoutinflater-binary",
370376
aar = ":asynclayoutinflater-binary-aar",
@@ -534,8 +540,14 @@ fb_native.remote_file(
534540

535541
fb_native.remote_file(
536542
name = "appcompat-binary-aar",
537-
sha1 = "002533a36c928bb27a3cc6843a25f83754b3c3ae",
538-
url = "mvn:androidx.appcompat:appcompat:aar:1.0.2",
543+
sha1 = "d384d125d196ed4997b418d7ba6fc18a4680ed22",
544+
url = "mvn:androidx.appcompat:appcompat:aar:1.4.1",
545+
)
546+
547+
fb_native.remote_file(
548+
name = "appcompat-resources-binary-aar",
549+
sha1 = "527d93d44bb18bc7dcf5213df8d4d069f0ceff61",
550+
url = "mvn:androidx.appcompat:appcompat-resources:aar:1.4.1",
539551
)
540552

541553
fb_native.remote_file(
@@ -558,8 +570,8 @@ fb_native.remote_file(
558570

559571
fb_native.remote_file(
560572
name = "core-binary-aar",
561-
sha1 = "263deba7f9c24bd0cefb93c0aaaf402cc50828ee",
562-
url = "mvn:androidx.core:core:aar:1.0.1",
573+
sha1 = "b26edc58f29ca0671e60828a68582760f880acdd",
574+
url = "mvn:androidx.core:core:aar:1.7.0",
563575
)
564576

565577
fb_native.remote_file(

0 commit comments

Comments
 (0)