Skip to content

Commit 574a773

Browse files
cortinicofacebook-github-bot
authored andcommitted
Do not remove libjscexecutor.so from release builds (#32932)
Summary: Pull Request resolved: #32932 As the title says, we dont' want to remove `libjscexecutor.so` when baking release builds and having JSC enable as this leads to instacrashes. Fixes #32928 Fixes #32927 Changelog: [Android] [Fixed] - Do not remove libjscexecutor.so from release builds Reviewed By: ShikaSD Differential Revision: D33681932 fbshipit-source-id: 5b59fd1fb76c80c191198d65c916bbbd9232c75b
1 parent ceb01db commit 574a773

File tree

2 files changed

+0
-8
lines changed

2 files changed

+0
-8
lines changed

packages/react-native-gradle-plugin/src/main/kotlin/com/facebook/react/TaskConfiguration.kt

-4
Original file line numberDiff line numberDiff line change
@@ -240,10 +240,6 @@ private fun Project.cleanupVMFiles(
240240
} else {
241241
// For JSC, delete all the libhermes* files
242242
it.include("**/libhermes*.so")
243-
// Delete the libjscexecutor from release build
244-
if (cleanup) {
245-
it.include("**/libjscexecutor.so")
246-
}
247243
}
248244
}
249245
.visit { visit ->

react.gradle

-4
Original file line numberDiff line numberDiff line change
@@ -372,10 +372,6 @@ afterEvaluate {
372372
} else {
373373
// For JSC, delete all the libhermes* files
374374
include "**/libhermes*.so"
375-
// Delete the libjscexecutor from release build
376-
if (cleanup) {
377-
include "**/libjscexecutor.so"
378-
}
379375
}
380376
}.visit { details ->
381377
def targetVariant1 = ".*/transforms/[^/]*/${variant.name}/.*"

0 commit comments

Comments
 (0)