Skip to content

Commit 56dfc86

Browse files
charpenifacebook-github-bot
authored andcommitted
Enable dev keyboard shortcuts on Mac Catalyst (#27479)
Summary: This enables the dev menu to bo opened from keyboard shortcuts in dev from a Mac Catalyst app. cc TheSavior andymatuschak radex ## Changelog [iOS] [Fixed] - Enable dev keyboard shortcuts on Mac Catalyst Pull Request resolved: #27479 Test Plan: It depends on #27469 (to have working WebSocket in debug). ![image](https://user-images.githubusercontent.com/7189823/70629346-d3a68880-1bf7-11ea-8949-7553157a2f9c.png) Differential Revision: D19576528 Pulled By: shergin fbshipit-source-id: 32b4f8424fb7d270640af4bc50dba24f488bef4f
1 parent 5d08aab commit 56dfc86

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

React/CoreModules/RCTDevMenu.mm

+1-1
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,7 @@ - (instancetype)init
122122
object:nil];
123123
_extraMenuItems = [NSMutableArray new];
124124

125-
#if TARGET_OS_SIMULATOR
125+
#if TARGET_OS_SIMULATOR || TARGET_OS_MACCATALYST
126126
RCTKeyCommands *commands = [RCTKeyCommands sharedInstance];
127127
__weak __typeof(self) weakSelf = self;
128128

React/CoreModules/RCTRedBox.mm

+1-1
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,7 @@ - (instancetype)initWithFrame:(CGRect)frame customButtonTitles:(NSArray<NSString
116116
_stackTraceTableView.indicatorStyle = UIScrollViewIndicatorStyleWhite;
117117
[rootView addSubview:_stackTraceTableView];
118118

119-
#if TARGET_OS_SIMULATOR
119+
#if TARGET_OS_SIMULATOR || TARGET_OS_MACCATALYST
120120
NSString *reloadText = @"Reload\n(\u2318R)";
121121
NSString *dismissText = @"Dismiss\n(ESC)";
122122
NSString *copyText = @"Copy\n(\u2325\u2318C)";

React/Modules/RCTRedBoxExtraDataViewController.m

+1-1
Original file line numberDiff line numberDiff line change
@@ -106,7 +106,7 @@ - (instancetype)init
106106
_tableView.rowHeight = UITableViewAutomaticDimension;
107107
_tableView.allowsSelection = NO;
108108

109-
#if TARGET_OS_SIMULATOR
109+
#if TARGET_OS_SIMULATOR || TARGET_OS_MACCATALYST
110110
NSString *reloadText = @"Reload JS (\u2318R)";
111111
NSString *dismissText = @"Dismiss (ESC)";
112112
#else

0 commit comments

Comments
 (0)