initalizeFlipper should be set in template app by default (#27569)

safaiyeh · facebook-github-bot · commit 52cd9cd6fec0 · 2020-01-30T03:09:30.000-08:00
Summary: Issue: #27565 initalizeFlipper should be set in template app by default. ## Changelog [iOS] [Changed] - Added Flipper to template app [Android] [Changed] - Added Flipper to template app Pull Request resolved: #27569 Test Plan: Connect Flipper to the iOS application Connect Flipper to the Android application Reviewed By: passy Differential Revision: D19344704 Pulled By: rickhanlonii fbshipit-source-id: ca126fd2caab13751ddc2ce6d195bd0c644c704e
diff --git a/template/android/app/src/main/java/com/helloworld/MainApplication.java b/template/android/app/src/main/java/com/helloworld/MainApplication.java
@@ -44,6 +44,7 @@ public ReactNativeHost getReactNativeHost() {
   public void onCreate() {
     super.onCreate();
     SoLoader.init(this, /* native exopackage */ false);
+    initializeFlipper(this, getReactNativeHost().getReactInstanceManager());
   }
 
   /**
diff --git a/template/ios/HelloWorld/AppDelegate.m b/template/ios/HelloWorld/AppDelegate.m
@@ -19,6 +19,7 @@ @implementation AppDelegate
 
 - (BOOL)application:(UIApplication *)application didFinishLaunchingWithOptions:(NSDictionary *)launchOptions
 {
+  [AppDelegate initializeFlipper:application];
   RCTBridge *bridge = [[RCTBridge alloc] initWithDelegate:self launchOptions:launchOptions];
   RCTRootView *rootView = [[RCTRootView alloc] initWithBridge:bridge
                                                    moduleName:@"HelloWorld"

Original file line number	Diff line number	Diff line change
`@@ -44,6 +44,7 @@ public ReactNativeHost getReactNativeHost() {`
`44`	`44`	`public void onCreate() {`
`45`	`45`	`super.onCreate();`
`46`	`46`	`SoLoader.init(this, /* native exopackage */ false);`
	`47`	`+ initializeFlipper(this, getReactNativeHost().getReactInstanceManager());`
`47`	`48`	`}`
`48`	`49`
`49`	`50`	`/**`
Original file line number	Diff line number	Diff line change
`@@ -19,6 +19,7 @@ @implementation AppDelegate`
`19`	`19`
`20`	`20`	`- (BOOL)application:(UIApplication )application didFinishLaunchingWithOptions:(NSDictionary )launchOptions`
`21`	`21`	`{`
	`22`	`+ [AppDelegate initializeFlipper:application];`
`22`	`23`	`RCTBridge *bridge = [[RCTBridge alloc] initWithDelegate:self launchOptions:launchOptions];`
`23`	`24`	`RCTRootView *rootView = [[RCTRootView alloc] initWithBridge:bridge`
`24`	`25`	`moduleName:@"HelloWorld"`