Skip to content

Commit 5050e7e

Browse files
GijsWeteringsfacebook-github-bot
authored andcommitted
Pass testID down in Modal
Summary: Changelog: [General][Fixed] - Modal accepts a testID but didn't forward it to RCTModalHostView, therefore not making it show up for e2e tests depending on viewhierarchy. Reviewed By: motiz88 Differential Revision: D32354377 fbshipit-source-id: 51df3a1f81c4b77240e83101b367b033ce98b0c7
1 parent 9d71b16 commit 5050e7e

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

Libraries/Modal/Modal.js

+2-1
Original file line numberDiff line numberDiff line change
@@ -264,7 +264,8 @@ class Modal extends React.Component<Props> {
264264
// $FlowFixMe[method-unbinding] added when improving typing for this parameters
265265
onStartShouldSetResponder={this._shouldSetResponder}
266266
supportedOrientations={this.props.supportedOrientations}
267-
onOrientationChange={this.props.onOrientationChange}>
267+
onOrientationChange={this.props.onOrientationChange}
268+
testID={this.props.testID}>
268269
<VirtualizedListContextResetter>
269270
<ScrollView.Context.Provider value={null}>
270271
<View

0 commit comments

Comments
 (0)