Skip to content

Commit 4ea6204

Browse files
Lucas Bentofacebook-github-bot
Lucas Bento
authored andcommitted
Do not run packager in Release mode (#24929)
Summary: This PR fixes a regression introduced on [3273d23](3273d23#diff-883359f85083d00b7266ec2acebcca9f) that removed #23938. It also adds the check for `React` and `React-tvOS` targets. ## Changelog [IOS] [FIXED] - Do not run packager in Release mode Pull Request resolved: #24929 Differential Revision: D15391692 Pulled By: cpojer fbshipit-source-id: c2e524108be3bf1e45b0d0ff7cddd9785b51a60f
1 parent fb8a7c3 commit 4ea6204

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

React/React.xcodeproj/project.pbxproj

+2-2
Original file line numberDiff line numberDiff line change
@@ -3975,7 +3975,7 @@
39753975
);
39763976
runOnlyForDeploymentPostprocessing = 0;
39773977
shellPath = /bin/sh;
3978-
shellScript = "terminal=\"${RCT_TERMINAL-${REACT_TERMINAL-$TERM_PROGRAM}}\"\n\nif [ -z \"${RCT_NO_LAUNCH_PACKAGER+xxx}\" ] ; then\n if nc -w 5 -z localhost 8081 ; then\n if ! curl -s \"http://localhost:8081/status\" | grep -q \"packager-status:running\" ; then\n echo \"Port 8081 already in use, packager is either not running or not running correctly\"\n exit 2\n fi\n elif [ -z \"$terminal\" ]; then\n open \"$SRCROOT/../scripts/launchPackager.command\" || echo \"Can't start packager automatically\"\n else\n open -a $terminal \"$SRCROOT/../scripts/launchPackager.command\" || echo \"Can't start packager automatically\"\n fi\nfi\n";
3978+
shellScript = "terminal=\"${RCT_TERMINAL-${REACT_TERMINAL-$TERM_PROGRAM}}\"\n\nif [ -z \"${RCT_NO_LAUNCH_PACKAGER+xxx}\" ] && [ \"$CONFIGURATION\" == \"Debug\" ] ; then\n if nc -w 5 -z localhost 8081 ; then\n if ! curl -s \"http://localhost:8081/status\" | grep -q \"packager-status:running\" ; then\n echo \"Port 8081 already in use, packager is either not running or not running correctly\"\n exit 2\n fi\n elif [ -z \"$terminal\" ]; then\n open \"$SRCROOT/../scripts/launchPackager.command\" || echo \"Can't start packager automatically\"\n else\n open -a $terminal \"$SRCROOT/../scripts/launchPackager.command\" || echo \"Can't start packager automatically\"\n fi\nfi\n";
39793979
showEnvVarsInLog = 0;
39803980
};
39813981
142C4F7F1B582EA6001F0B58 /* Include RCTJSCProfiler */ = {
@@ -4095,7 +4095,7 @@
40954095
);
40964096
runOnlyForDeploymentPostprocessing = 0;
40974097
shellPath = /bin/sh;
4098-
shellScript = "terminal=\"${RCT_TERMINAL-${REACT_TERMINAL-$TERM_PROGRAM}}\"\n\nif [ -z \"${RCT_NO_LAUNCH_PACKAGER+xxx}\" ] ; then\n if nc -w 5 -z localhost 8081 ; then\n if ! curl -s \"http://localhost:8081/status\" | grep -q \"packager-status:running\" ; then\n echo \"Port 8081 already in use, packager is either not running or not running correctly\"\n exit 2\n fi\n elif [ -z \"$terminal\" ]; then\n open \"$SRCROOT/../scripts/launchPackager.command\" || echo \"Can't start packager automatically\"\n else\n open -a $terminal \"$SRCROOT/../scripts/launchPackager.command\" || echo \"Can't start packager automatically\"\n fi\nfi\n";
4098+
shellScript = "terminal=\"${RCT_TERMINAL-${REACT_TERMINAL-$TERM_PROGRAM}}\"\n\nif [ -z \"${RCT_NO_LAUNCH_PACKAGER+xxx}\" ] && [ \"$CONFIGURATION\" == \"Debug\" ] ; then\n if nc -w 5 -z localhost 8081 ; then\n if ! curl -s \"http://localhost:8081/status\" | grep -q \"packager-status:running\" ; then\n echo \"Port 8081 already in use, packager is either not running or not running correctly\"\n exit 2\n fi\n elif [ -z \"$terminal\" ]; then\n open \"$SRCROOT/../scripts/launchPackager.command\" || echo \"Can't start packager automatically\"\n else\n open -a $terminal \"$SRCROOT/../scripts/launchPackager.command\" || echo \"Can't start packager automatically\"\n fi\nfi\n";
40994099
showEnvVarsInLog = 0;
41004100
};
41014101
3D383D3E1EBD27B9005632C8 /* Install Third Party */ = {

0 commit comments

Comments
 (0)