Skip to content

Commit 4b25a0a

Browse files
iBotPeachesfacebook-github-bot
authored andcommitted
feat: add missing Android dangerous permissions (#32445)
Summary: This PR adds all missing `dangerous` permissions in Android. I recently updated these for Android 12 and found many more missing dating all the way back to API 26. After this PR, it will be in sync with ALL dangerous permissions as of the recently released Android 12. https://developer.android.com/reference/android/Manifest.permission.html#ACCEPT_HANDOVER - 28 https://developer.android.com/reference/android/Manifest.permission.html#ACTIVITY_RECOGNITION - 29 https://developer.android.com/reference/android/Manifest.permission.html#ANSWER_PHONE_CALLS - 26 https://developer.android.com/reference/android/Manifest.permission.html#READ_PHONE_NUMBERS - 26 https://developer.android.com/reference/android/Manifest.permission.html#UWB_RANGING - 31 ## Changelog [Android] [Changed] - Add ACCEPT_HANDOVER, ACTIVITY_RECOGNITION, ANSWER_PHONE_CALLS, READ_PHONE_NUMBERS & UWB_RANGING to PermissionsAndroid Pull Request resolved: #32445 Test Plan: ``` PermissionsAndroid.ACCEPT_HANDOVER === 'android.permission.ACCEPT_HANDOVER' PermissionsAndroid.ACTIVITY_RECOGNITION === 'android.permission.ACTIVITY_RECOGNITION' PermissionsAndroid.ANSWER_PHONE_CALLS === 'android.permission.ANSWER_PHONE_CALLS' PermissionsAndroid.READ_PHONE_NUMBERS === 'android.permission.READ_PHONE_NUMBERS' PermissionsAndroid.UWB_RANGING === 'android.permission.UWB_RANGING' ``` Reviewed By: yungsters Differential Revision: D31793802 Pulled By: sshic fbshipit-source-id: 4a2e5086e92ccd223e74db451c4ccd87485ffb63
1 parent b03e824 commit 4b25a0a

File tree

2 files changed

+16
-1
lines changed

2 files changed

+16
-1
lines changed

Libraries/PermissionsAndroid/NativePermissionsAndroid.js

+6-1
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,12 @@ export type PermissionType =
4545
| 'android.permission.BLUETOOTH_CONNECT'
4646
| 'android.permission.BLUETOOTH_SCAN'
4747
| 'android.permission.BLUETOOTH_ADVERTISE'
48-
| 'android.permission.ACCESS_MEDIA_LOCATION';
48+
| 'android.permission.ACCESS_MEDIA_LOCATION'
49+
| 'android.permission.ACCEPT_HANDOVER'
50+
| 'android.permission.ACTIVITY_RECOGNITION'
51+
| 'android.permission.ANSWER_PHONE_CALLS'
52+
| 'android.permission.READ_PHONE_NUMBERS'
53+
| 'android.permission.UWB_RANGING';
4954
*/
5055

5156
export interface Spec extends TurboModule {

Libraries/PermissionsAndroid/PermissionsAndroid.js

+10
Original file line numberDiff line numberDiff line change
@@ -63,6 +63,11 @@ const PERMISSIONS = Object.freeze({
6363
BLUETOOTH_SCAN: 'android.permission.BLUETOOTH_SCAN',
6464
BLUETOOTH_ADVERTISE: 'android.permission.BLUETOOTH_ADVERTISE',
6565
ACCESS_MEDIA_LOCATION: 'android.permission.ACCESS_MEDIA_LOCATION',
66+
ACCEPT_HANDOVER: 'android.permission.ACCEPT_HANDOVER',
67+
ACTIVITY_RECOGNITION: 'android.permission.ACTIVITY_RECOGNITION',
68+
ANSWER_PHONE_CALLS: 'android.permission.ANSWER_PHONE_CALLS',
69+
READ_PHONE_NUMBERS: 'android.permission.READ_PHONE_NUMBERS',
70+
UWB_RANGING: 'android.permission.UWB_RANGING',
6671
});
6772

6873
/**
@@ -73,11 +78,14 @@ const PERMISSIONS = Object.freeze({
7378

7479
class PermissionsAndroid {
7580
PERMISSIONS: {|
81+
ACCEPT_HANDOVER: string,
7682
ACCESS_BACKGROUND_LOCATION: string,
7783
ACCESS_COARSE_LOCATION: string,
7884
ACCESS_FINE_LOCATION: string,
7985
ACCESS_MEDIA_LOCATION: string,
86+
ACTIVITY_RECOGNITION: string,
8087
ADD_VOICEMAIL: string,
88+
ANSWER_PHONE_CALLS: string,
8189
BLUETOOTH_ADVERTISE: string,
8290
BLUETOOTH_CONNECT: string,
8391
BLUETOOTH_SCAN: string,
@@ -90,6 +98,7 @@ class PermissionsAndroid {
9098
READ_CALL_LOG: string,
9199
READ_CONTACTS: string,
92100
READ_EXTERNAL_STORAGE: string,
101+
READ_PHONE_NUMBERS: string,
93102
READ_PHONE_STATE: string,
94103
READ_SMS: string,
95104
RECEIVE_MMS: string,
@@ -98,6 +107,7 @@ class PermissionsAndroid {
98107
RECORD_AUDIO: string,
99108
SEND_SMS: string,
100109
USE_SIP: string,
110+
UWB_RANGING: string,
101111
WRITE_CALENDAR: string,
102112
WRITE_CALL_LOG: string,
103113
WRITE_CONTACTS: string,

0 commit comments

Comments
 (0)