Pop frames correctly in console.error handler

motiz88 · facebook-github-bot · commit 3eaf2455402b · 2019-08-05T11:19:56.000-07:00
Reviewed By: cpojer

Differential Revision: D16648992

fbshipit-source-id: 4581e2cd6859f27bc384fc3ab328ab5b9414c704
diff --git a/Libraries/Core/ExceptionsManager.js b/Libraries/Core/ExceptionsManager.js
@@ -134,7 +134,7 @@ function reactConsoleErrorHandler() {
     }
     const error: ExtendedError = new SyntheticError(str);
     error.name = 'console.error';
-    error.framesToPop = 1;
+    error.framesToPop = (error.framesToPop || 0) + 1;
     reportException(error, /* isFatal */ false);
   }
 }

Original file line number	Diff line number	Diff line change
`@@ -134,7 +134,7 @@ function reactConsoleErrorHandler() {`
`134`	`134`	`}`
`135`	`135`	`const error: ExtendedError = new SyntheticError(str);`
`136`	`136`	`error.name = 'console.error';`
`137`		`- error.framesToPop = 1;`
	`137`	`+ error.framesToPop = (error.framesToPop \|\| 0) + 1;`
`138`	`138`	`reportException(error, /* isFatal */ false);`
`139`	`139`	`}`
`140`	`140`	`}`