Skip to content

Commit 3e5998e

Browse files
IjzerenHeinfacebook-github-bot
authored andcommitted
Fix dashed/dotted border drawing when border-radius is 0 (#28359)
Summary: This PR fixes the border-style that is not respected when drawing a border with 0 border-radius on Android. This would cause the faster `drawRectangularBackgroundWithBorders` path to be used, but that uses rectangular drawing and doesn't support dashed/dotted stroke patterns. This PR changes the behavior to use the generic `drawRoundedBackgroundWithBorders` code-path which does support dashed/dotted border-styles. ## Changelog `[Android] [Fixed] - Fix dashed/dotted border-drawing when border-radius is 0` Pull Request resolved: #28359 Test Plan: **Faulty situation:** ![Screenshot_1584721992](https://user-images.githubusercontent.com/6184593/77184987-e838cd80-6ad0-11ea-9585-058eafbd361a.png) **After the fix:** ![Screenshot_1584721410](https://user-images.githubusercontent.com/6184593/77184801-9d1eba80-6ad0-11ea-92a7-7212f40ace73.png) Reviewed By: lunaleaps Differential Revision: D20590739 Pulled By: charlesbdudley fbshipit-source-id: 18657ea21e54f763e22c623bf979b3500c1bdcbd
1 parent 913448f commit 3e5998e

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

ReactAndroid/src/main/java/com/facebook/react/views/view/ReactViewBackgroundDrawable.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,7 @@ public ReactViewBackgroundDrawable(Context context) {
129129
@Override
130130
public void draw(Canvas canvas) {
131131
updatePathEffect();
132-
if (!hasRoundedBorders()) {
132+
if (!hasRoundedBorders() && mBorderStyle == BorderStyle.SOLID) {
133133
drawRectangularBackgroundWithBorders(canvas);
134134
} else {
135135
drawRoundedBackgroundWithBorders(canvas);

0 commit comments

Comments
 (0)