Skip to content

Commit 3a41f69

Browse files
janicduplessisfacebook-github-bot
authored andcommitted
Make sure js bundle still exists at bundle-output path (#30149)
Summary: Since changes to support hermes on iOS the js bundled is moved away from the location where it is generated when calling metro. This causes issues with the RN sentry integration since it relies on intercepting this path to find the bundle file after running react-native-xcode.sh. Seems kind of like a hacky way to get the bundle location, but let's avoid breaking it. https://github.com/getsentry/sentry-cli/blob/master/src/commands/react_native_xcode.rs ## Changelog [iOS] [Fixed] - Make sure js bundle still exists at bundle-output path Pull Request resolved: #30149 Test Plan: Checked that the bundle file exists both at bundle-output path and in the .app. Checked that the sentry release script works. Reviewed By: cpojer Differential Revision: D24480115 Pulled By: appden fbshipit-source-id: c01c80d47ed54319f97063ec635c021552a95c22
1 parent bfbd841 commit 3a41f69

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

scripts/react-native-xcode.sh

+1-1
Original file line numberDiff line numberDiff line change
@@ -168,7 +168,7 @@ fi
168168
$EXTRA_PACKAGER_ARGS
169169

170170
if [[ $USE_HERMES != true ]]; then
171-
mv "$BUNDLE_FILE" "$DEST/"
171+
cp "$BUNDLE_FILE" "$DEST/"
172172
BUNDLE_FILE="$DEST/main.jsbundle"
173173
else
174174
EXTRA_COMPILER_ARGS=

0 commit comments

Comments
 (0)