Skip to content

Commit 383934a

Browse files
Emily Janzerfacebook-github-bot
Emily Janzer
authored andcommitted
Don't emit dimensions update event on initial load
Summary: On iOS we don't emit the didUpdateDimensions event in JS when the first React Native screen is rendered, so let's keep the behavior the same on Android. Reviewed By: mdvacca Differential Revision: D19506829 fbshipit-source-id: d0122d18be79177318c3f059ed396f990eeabcb7
1 parent 86fd4b5 commit 383934a

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

ReactAndroid/src/main/java/com/facebook/react/modules/deviceinfo/DeviceInfoModule.java

+3-1
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,9 @@ public void emitUpdateDimensionsEvent() {
8989
// Don't emit an event to JS if the dimensions haven't changed
9090
WritableNativeMap displayMetrics =
9191
DisplayMetricsHolder.getDisplayMetricsNativeMap(mFontScale);
92-
if (!displayMetrics.equals(mPreviousDisplayMetrics)) {
92+
if (mPreviousDisplayMetrics == null) {
93+
mPreviousDisplayMetrics = displayMetrics.copy();
94+
} else if (!displayMetrics.equals(mPreviousDisplayMetrics)) {
9395
mPreviousDisplayMetrics = displayMetrics.copy();
9496
mReactApplicationContext
9597
.getJSModule(DeviceEventManagerModule.RCTDeviceEventEmitter.class)

0 commit comments

Comments
 (0)