Skip to content

Commit 35fc0ad

Browse files
passyfacebook-github-bot
authored andcommitted
Remove vendored proguard annotation (#26069)
Summary: There have been multiple complaints about combining RN with various other FB libraries, including Litho and Flipper, because of bundled dependencies that can't be deduplicated by Gradle. This is one of three current conflicts: 1) Proguard annotations (this PR) 2) Yoga 3) fbjni While the Yoga group name doesn't make a massive amount of sense it was the easiest existing package to use and since we don't have a better namespace for this, we might as well use this. A similar change to Litho is landing right now. ## Changelog [Android] [Changed] - Use centralized package for DoNotStrip annotation Pull Request resolved: #26069 Test Plan: ``` yarn ./gradlew :RNTester:android:app:assembleDebug ``` Reviewed By: cpojer Differential Revision: D16827430 Pulled By: passy fbshipit-source-id: 87542b5422fee598d8e635651441f0ecd42eb9d7
1 parent a206e91 commit 35fc0ad

File tree

2 files changed

+1
-22
lines changed

2 files changed

+1
-22
lines changed

ReactAndroid/build.gradle

+1
Original file line numberDiff line numberDiff line change
@@ -356,6 +356,7 @@ android {
356356

357357
dependencies {
358358
api("com.facebook.infer.annotation:infer-annotation:0.11.2")
359+
api("com.facebook.yoga:proguard-annotations:1.14.1")
359360
api("javax.inject:javax.inject:1")
360361
api("androidx.appcompat:appcompat:1.0.2")
361362
api("com.facebook.fresco:fresco:${FRESCO_VERSION}")

ReactAndroid/src/main/java/com/facebook/proguard/annotations/DoNotStrip.java

-22
This file was deleted.

0 commit comments

Comments
 (0)