Skip to content

Commit 2db1bca

Browse files
Kerumenfacebook-github-bot
authored andcommitted
Remove prettier from dependencies (#33125)
Summary: `prettier` should not be declared in dependencies in the ESLint config because it can trigger issues when a different version is installed on the client app. `prettier` is already declared as `peerDependencies` and in the [README](https://github.com/facebook/react-native/blob/main/packages/eslint-config-react-native-community/README.md), it's explicitly asked to install it: ``` yarn add --dev eslint prettier react-native-community/eslint-config ``` ## Changelog <!-- Help reviewers and the release process by writing your own changelog entry. For an example, see: https://github.com/facebook/react-native/wiki/Changelog --> [General] [Fixed] - Remove prettier from dependencies in eslint-config Pull Request resolved: #33125 Test Plan: - Install the package `react-native-community/eslint-config` and ensure everything works the same as before Reviewed By: yungsters Differential Revision: D34305118 Pulled By: ShikaSD fbshipit-source-id: 65a3a79008cd5e28cc6aa93ef4a5032990b4e9f8
1 parent 3580096 commit 2db1bca

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

packages/eslint-config-react-native-community/package.json

+1-2
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,7 @@
2222
"eslint-plugin-prettier": "^4.0.0",
2323
"eslint-plugin-react": "^7.26.1",
2424
"eslint-plugin-react-hooks": "^4.2.0",
25-
"eslint-plugin-react-native": "^3.11.0",
26-
"prettier": "^2.4.1"
25+
"eslint-plugin-react-native": "^3.11.0"
2726
},
2827
"peerDependencies": {
2928
"eslint": ">=7",

0 commit comments

Comments
 (0)