Skip to content

Commit 2d64d1d

Browse files
TatianaKaposfacebook-github-bot
authored andcommitted
Fix RawPropsParser for Windows (#33432)
Summary: Changes in 7cece34...189c2c8 broke build for Windows because of a conversion from size_t to int. Adds a static cast to int to fix the error and restore windows build Error Message ``` ##[error]node_modules\react-native\ReactCommon\react\renderer\core\RawPropsParser.cpp(100,42): Error C2220: the following warning is treated as an error 3>D:\a\_work\1\s\node_modules\react-native\ReactCommon\react\renderer\core\RawPropsParser.cpp(100,42): error C2220: the following warning is treated as an error [D:\a\_work\1\s\vnext\Microsoft.ReactNative\Microsoft.ReactNative.vcxproj] ##[warning]node_modules\react-native\ReactCommon\react\renderer\core\RawPropsParser.cpp(100,42): **Warning C4267: '=': conversion from 'size_t' to 'int', possible loss of data** 3>D:\a\_work\1\s\node_modules\react-native\ReactCommon\react\renderer\core\RawPropsParser.cpp(100,42): warning C4267: '=': conversion from 'size_t' to 'int', possible loss of data [D:\a\_work\1\s\vnext\Microsoft.ReactNative\Microsoft.ReactNative.vcxproj] ``` ## Changelog [General] [Fixed] - Restore Windows build with RawPropsParser.cpp Pull Request resolved: #33432 Test Plan: Tested locally and changes pass in the react-native-windows pipeline, change is being merged into the main branch of react-native-windows. Reviewed By: philIip Differential Revision: D34907928 Pulled By: javache fbshipit-source-id: 8b76cbef0b637f2d607a8aefd2998322c3245713
1 parent b2517c3 commit 2d64d1d

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

ReactCommon/react/renderer/core/RawPropsParser.cpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@ void RawPropsParser::preparse(RawProps const &rawProps) const noexcept {
9797
rawProps.keyIndexToValueIndex_.resize(keyCount, kRawPropsValueIndexEmpty);
9898

9999
// Resetting the cursor, the next increment will give `0`.
100-
rawProps.keyIndexCursor_ = keyCount - 1;
100+
rawProps.keyIndexCursor_ = static_cast<int>(keyCount - 1);
101101

102102
switch (rawProps.mode_) {
103103
case RawProps::Mode::Empty:

0 commit comments

Comments
 (0)