Skip to content

Commit 23036b3

Browse files
Ashoatfacebook-github-bot
authored andcommitted
Set windowTranslucentNavigation to false (#29399)
Summary: This fixes #29397. Without this, apps that specify `android:windowTranslucentNavigation` draw the `LogBox` buttons underneath the soft navigation bar, making the buttons unpressable. Before | After :-------------------------:|:-------------------------: <img src="http://ashoat.com/AndroidTranslucentNavigationLogBox.png" width="300" /> | <img src="http://ashoat.com/AndroidTranslucentNavigationLogBoxFixed.png" width="300" /> ## Changelog [Android] [Fixed] - Set LogBox windowTranslucentNavigation to false Pull Request resolved: #29399 Test Plan: I tested this change on the [repo](https://github.com/Ashoat/LogBoxTest) I set up to reproduce the issue. I set it up to [build `ReactAndroid` from source](Ashoat/LogBoxTest@3a2cdab) and then edited `node_modules/react-native/ReactAndroid/src/main/res/devsupport/values/styles.xml` directly. Reviewed By: rickhanlonii Differential Revision: D22602970 Pulled By: mdvacca fbshipit-source-id: 8c2adc149aa0157825075022f00bb695956d3121
1 parent f7eacf0 commit 23036b3

File tree

1 file changed

+1
-0
lines changed
  • ReactAndroid/src/main/res/devsupport/values

1 file changed

+1
-0
lines changed

ReactAndroid/src/main/res/devsupport/values/styles.xml

+1
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@
1111
</style>
1212
<style name="Theme.Catalyst.LogBox">
1313
<item name="android:windowTranslucentStatus">true</item>
14+
<item name="android:windowTranslucentNavigation">false</item>
1415
<item name="android:windowBackground">@android:color/transparent</item>
1516
<item name="android:windowAnimationStyle">@style/Animation.Catalyst.LogBox</item>
1617
<item name="android:inAnimation">@android:anim/fade_in</item>

0 commit comments

Comments
 (0)