Skip to content

Commit 20b0eba

Browse files
janicduplessisfacebook-github-bot
authored andcommitted
Static link for hermes-inspector (#32694)
Summary: Follow up to #32683 to also link hermes-inspector statically. ## Changelog [Android] [Fix] - Static link for hermes-inspector Pull Request resolved: #32694 Test Plan: Tested a clean build and made sure hermes-inspector.so doesn't exist anymore. Reviewed By: cortinico Differential Revision: D32791208 Pulled By: ShikaSD fbshipit-source-id: 6076b263469b9e2c6176d488d13292d4f1731dcc
1 parent b30ff98 commit 20b0eba

File tree

4 files changed

+2
-4
lines changed

4 files changed

+2
-4
lines changed

ReactAndroid/src/main/java/com/facebook/hermes/reactexecutor/Android.mk

+1-1
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ LOCAL_C_INCLUDES := $(LOCAL_PATH) $(REACT_NATIVE)/ReactCommon/jsi $(call find-no
4040

4141
LOCAL_CPP_FEATURES := exceptions
4242

43-
LOCAL_STATIC_LIBRARIES := libjsireact libhermes-executor-common-debug libhermes-inspector
43+
LOCAL_STATIC_LIBRARIES := libjsireact libhermes-executor-common-debug
4444
LOCAL_SHARED_LIBRARIES := \
4545
libfb \
4646
libfbjni \

ReactCommon/hermes/inspector/Android.mk

+1-1
Original file line numberDiff line numberDiff line change
@@ -31,4 +31,4 @@ LOCAL_SHARED_LIBRARIES := \
3131
libhermes \
3232
libjsi
3333

34-
include $(BUILD_SHARED_LIBRARY)
34+
include $(BUILD_STATIC_LIBRARY)

packages/react-native-gradle-plugin/src/main/kotlin/com/facebook/react/TaskConfiguration.kt

-1
Original file line numberDiff line numberDiff line change
@@ -231,7 +231,6 @@ private fun Project.cleanupVMFiles(
231231

232232
if (cleanup) {
233233
// Reduce size by deleting the debugger/inspector
234-
it.include("**/libhermes-inspector.so")
235234
it.include("**/libhermes-executor-debug.so")
236235
} else {
237236
// Release libs take precedence and must be removed

react.gradle

-1
Original file line numberDiff line numberDiff line change
@@ -363,7 +363,6 @@ afterEvaluate {
363363

364364
if (cleanup) {
365365
// Reduce size by deleting the debugger/inspector
366-
include '**/libhermes-inspector.so'
367366
include '**/libhermes-executor-debug.so'
368367
} else {
369368
// Release libs take precedence and must be removed

0 commit comments

Comments
 (0)