Skip to content

Commit 1fbc6a7

Browse files
Peter Arganyfacebook-github-bot
Peter Argany
authored andcommitted
Fix animations in OSS debug builds by modifying Platform.isTesting() behaviour
Summary: In D14244606 I "fixed" `Platform.isTesting()` in JS. By fixed, I made it return true when running SSTs. People in OSS complained about this in discord and [github](#27010). The problem is that this call returns true whenever an RN project references Detox in the build.gradle file. In practice, this has been really annoying, because it has disabled animations in debug builds, due to D13811035. The fix is to be more specific, and look for the exact screenshot test activity. I haven't explicitly verified this doesn't trigger from Detox, but it shouldn't. I'll coordinate on the github issue to verify. Changelog: [Android][Fixed] Fix animations in OSS debug builds by modifying `Platform.isTesting()` behaviour Reviewed By: TheSavior Differential Revision: D19384098 fbshipit-source-id: 22c885219f2c00f5dcc3b930b068bfd2ad7e4b8e
1 parent cfbd93c commit 1fbc6a7

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

ReactAndroid/src/main/java/com/facebook/react/modules/systeminfo/AndroidInfoModule.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ public void invalidate() {}
9292

9393
private Boolean isRunningScreenshotTest() {
9494
try {
95-
Class.forName("android.support.test.rule.ActivityTestRule");
95+
Class.forName("com.facebook.testing.react.screenshots.ReactAppScreenshotTestActivity");
9696
return true;
9797
} catch (ClassNotFoundException ignored) {
9898
return false;

0 commit comments

Comments
 (0)