Skip to content

Commit 1db96a3

Browse files
janicduplessisfacebook-github-bot
authored andcommitted
Add missing hermes include (#25872)
Summary: The Hermes react executor c++ code is not currently getting built. The include was probably forgotten when merging hermes on master. The 0.60 branch does have it https://github.com/facebook/react-native/blob/0.60-stable/ReactAndroid/src/main/jni/react/jni/Android.mk#L72 ## Changelog [Android] [Fixed] - Add missing hermes include Pull Request resolved: #25872 Test Plan: Run an app with hermes enabled on RN master Differential Revision: D16559354 Pulled By: cpojer fbshipit-source-id: 95cfbf65481c2f0d0e5c53ca35f327753e7b99ae
1 parent bf5e73e commit 1db96a3

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

ReactAndroid/src/main/jni/react/jni/Android.mk

+1
Original file line numberDiff line numberDiff line change
@@ -77,3 +77,4 @@ include $(REACT_SRC_DIR)/turbomodule/core/jni/Android.mk
7777
# $(call import-module,jscexecutor)
7878

7979
include $(REACT_SRC_DIR)/jscexecutor/Android.mk
80+
include $(REACT_SRC_DIR)/../hermes/reactexecutor/Android.mk

0 commit comments

Comments
 (0)